From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks Date: Wed, 18 Dec 2013 15:38:19 +0400 Message-ID: <52B1892B.1020806@cogentembedded.com> References: <1387316678-10174-1-git-send-email-wsa@the-dreams.de> <1387316678-10174-3-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1387316678-10174-3-git-send-email-wsa@the-dreams.de> Sender: linux-sh-owner@vger.kernel.org To: Wolfram Sang , linux-sh@vger.kernel.org Cc: linux-i2c@vger.kernel.org, Magnus Damm , Laurent Pinchart , Simon Horman , linux-arm-kernel@lists.infradead.org List-Id: linux-i2c@vger.kernel.org Hello. On 18-12-2013 1:44, Wolfram Sang wrote: > From: Wolfram Sang > Tested with RIIC2 on a genmai board. Others untested but hopefully > trivial enough to be added. > Signed-off-by: Wolfram Sang > Acked-by: Magnus Damm > --- > arch/arm/mach-shmobile/clock-r7s72100.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > diff --git a/arch/arm/mach-shmobile/clock-r7s72100.c b/arch/arm/mach-shmobile/clock-r7s72100.c > index 7b457ae..770316d 100644 > --- a/arch/arm/mach-shmobile/clock-r7s72100.c > +++ b/arch/arm/mach-shmobile/clock-r7s72100.c [...] > @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { > CLKDEV_CON_ID("mtu2_fck", &mstp_clks[MSTP33]), > > /* ICK */ > + CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]), > + CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]), > + CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]), > + CLKDEV_DEV_ID("fcfeec00.i2c", &mstp_clks[MSTP94]), These belong to some other place, the group marked by /* ICK */ is only for CLKDEV_ICK_ID(). > CLKDEV_ICK_ID("sci_fck", "sh-sci.0", &mstp_clks[MSTP47]), > CLKDEV_ICK_ID("sci_fck", "sh-sci.1", &mstp_clks[MSTP46]), > CLKDEV_ICK_ID("sci_fck", "sh-sci.2", &mstp_clks[MSTP45]), WBR, Sergei