From: Tomasz Figa <t.figa@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Thomas Abraham <thomas.abraham@linaro.org>,
linux-i2c@vger.kernel.org, kgene.kim@samsung.com,
patches@linaro.org, linus.walleij@linaro.org,
swarren@wwwdotorg.org, w.sang@pengutronix.de,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
dong.aisheng@linaro.org
Subject: Re: [PATCH 2/2] ARM: dts: exynos4: allow i2c0 bus to be configured using pinctrl interface
Date: Thu, 06 Sep 2012 12:13:11 +0200 [thread overview]
Message-ID: <5320531.svfjn4BD9X@amdc1227> (raw)
In-Reply-To: <1346923381-14144-3-git-send-email-thomas.abraham@linaro.org>
Hi Thomas,
On Thursday 06 of September 2012 14:53:01 Thomas Abraham wrote:
> compatible = "samsung,s3c2440-i2c";
> reg = <0x13860000 0x100>;
> interrupts = <0 58 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_bus>;
If pinctrl-names property is omitted then the state index is used as a name
(e.g. pinctrl-0 would be named "0"). Maybe it would be better to use this
approach (with respective adjustment in first patch)? What do you think?
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
next prev parent reply other threads:[~2012-09-06 10:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 9:22 [PATCH 0/2] i2c: s3c2410: allow pin pin configuration using pinctrl Thomas Abraham
2012-09-06 9:23 ` [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface Thomas Abraham
2012-09-06 9:34 ` Tomasz Figa
2012-09-06 11:06 ` Thomas Abraham
2012-09-06 12:28 ` Tomasz Figa
2012-09-10 19:55 ` Linus Walleij
2012-09-10 19:21 ` Stephen Warren
[not found] ` <504E3DBA.3080603-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-17 7:28 ` Thomas Abraham
2012-09-10 20:02 ` Linus Walleij
[not found] ` <CACRpkdZ7kjfDQ-CNCcCv5fQwSqMez6sKSMUMLB=0Aviboiz=2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-17 7:52 ` Thomas Abraham
[not found] ` <1346923381-14144-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-06 9:23 ` [PATCH 2/2] ARM: dts: exynos4: allow i2c0 bus to be configured " Thomas Abraham
2012-09-06 10:13 ` Tomasz Figa [this message]
2012-09-06 11:14 ` Thomas Abraham
2012-09-10 19:23 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5320531.svfjn4BD9X@amdc1227 \
--to=t.figa@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dong.aisheng@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=thomas.abraham@linaro.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox