linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	boris-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org
Subject: Re: I2C adapters protocol deviation
Date: Sun, 06 Apr 2014 16:01:52 +0200	[thread overview]
Message-ID: <53415E50.9000402@redhat.com> (raw)
In-Reply-To: <20140404122632.GA3686@katana>

Hi,

On 04/04/2014 02:26 PM, Wolfram Sang wrote:
> 
>> So what we really have is a single slave i2c host sort of. At least
>> we could model it like that. The host could be told which address to
>> listen to (and which single i2c write to do to init the pmic) through
>> devicetree and then all the differences would be hidden in the host
>> driver, ie we would check the slave-address and if it is not the single
>> one we support, we just return the appropriate error for a device not
>> acking, and everything should work as a regular i2c host which
>> only supports i2c_smbus_read_byte and i2c_smbus_write_byte.
> 
> I'd think we need a new message flag like I2C_M_PUSHPULL which says that
> this message has only the direction bit instead of the address and needs
> a parity bit afterwards. In addition to that, we need a new
> functionality flag I2C_FUNC_PUSHPULL which means the host driver can
> handle those messages. So, the PMIC driver could query support for
> I2C_FUNC_SMBUS_BYTE | I2C_FUNC_PUSHPULL and if successful send messages
> using smbus functions with the new flag set.

Thanks for the input this sounds good, I guess we'll give this a shot
when we get around to coding up support for the p2wi block in the A31.

> Not sure about the I2C-to-PushPull switch: Is it 100% host configuration
> or does it also depend on the one slave attached? 

The datasheet we've suggests that it actually influences the one slave
attached. Note that u-boot on this machines will likely already have made
the switch, but I guess we don't want to count on that.

> Are there some datasheets available?

The AXP221 is documented here:
http://linux-sunxi.org/AXP221
This is translated by one of our community members from a Chinese datasheet.

The P2WI interface is (somewhat) documented in the A31 datasheet, but we cannot
share that in public.

Regards,

Hans

  reply	other threads:[~2014-04-06 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 14:55 I2C adapters protocol deviation Maxime Ripard
2014-04-03 15:30 ` Hans de Goede
     [not found]   ` <533D7E81.4050900-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-04 11:49     ` Maxime Ripard
2014-04-04 12:26     ` Wolfram Sang
2014-04-06 14:01       ` Hans de Goede [this message]
     [not found]         ` <53415E50.9000402-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-06 15:37           ` Wolfram Sang
2014-04-06 17:18             ` Hans de Goede
     [not found]               ` <53418C61.6020604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-07  7:49                 ` Boris BREZILLON
     [not found]                   ` <5342589B.5000600-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-04-07 12:06                     ` Hans de Goede
2014-04-07  8:15                 ` Maxime Ripard
2014-04-07 12:07                   ` Hans de Goede
2014-04-07  8:01             ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53415E50.9000402@redhat.com \
    --to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=boris-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).