From: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Sachin Kamat
<sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
spk.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.orgWolfram Sang
<wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Subject: Re: [PATCH 1/1] i2c: sun6i-p2wi: Remove duplicate inclusion of module.h
Date: Mon, 23 Jun 2014 14:08:45 +0200 [thread overview]
Message-ID: <53A818CD.40205@free-electrons.com> (raw)
In-Reply-To: <1403522017-13861-1-git-send-email-sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On 23/06/2014 13:13, Sachin Kamat wrote:
> module.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-sun6i-p2wi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c
> index 09de4fd12d57..558fd24573b2 100644
> --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c
> +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c
> @@ -26,7 +26,6 @@
> #include <linux/i2c.h>
> #include <linux/io.h>
> #include <linux/interrupt.h>
> -#include <linux/module.h>
Oops, I guess this was introduced when I reordered inclusions in
alphabetic order.
I'd prefer the other inclusion to be removed instead, so that we could
keep it in alphabetic order.
Other than that you have my:
Acked-by: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-23 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 11:13 [PATCH 1/1] i2c: sun6i-p2wi: Remove duplicate inclusion of module.h Sachin Kamat
[not found] ` <1403522017-13861-1-git-send-email-sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-23 12:08 ` Boris BREZILLON [this message]
[not found] ` <53A818CD.40205-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-06-24 3:47 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A818CD.40205@free-electrons.com \
--to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=sachin.kamat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=spk.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.orgWolfram \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox