linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Fabio Estevam
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH] i2c: i2c-st: Use %pa to print 'resource_size_t' type
Date: Fri, 11 Jul 2014 09:16:35 +0200	[thread overview]
Message-ID: <53BF8F53.1040701@st.com> (raw)
In-Reply-To: <1405034605-21757-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi Fabio,

On 07/11/2014 01:23 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
> is seen:
>
> drivers/i2c/busses/i2c-st.c:818:2: warning: format '%x' expects argument of type
> 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat=]
>
> Use %pa to print 'resource_size_t' type to fix the warning.
>
> Reported-by: Olof's autobuilder <build-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>   drivers/i2c/busses/i2c-st.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>

Thanks!
Maxime

>
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index 95b94767..fc767dd 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -815,7 +815,7 @@ static int st_i2c_probe(struct platform_device *pdev)
>
>   	adap = &i2c_dev->adap;
>   	i2c_set_adapdata(adap, i2c_dev);
> -	snprintf(adap->name, sizeof(adap->name), "ST I2C(0x%x)", res->start);
> +	snprintf(adap->name, sizeof(adap->name), "ST I2C(0x%pa)", &res->start);
>   	adap->owner = THIS_MODULE;
>   	adap->timeout = 2 * HZ;
>   	adap->retries = 0;
>

  parent reply	other threads:[~2014-07-11  7:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 23:23 [PATCH] i2c: i2c-st: Use %pa to print 'resource_size_t' type Fabio Estevam
     [not found] ` <1405034605-21757-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-11  7:16   ` Maxime Coquelin [this message]
2014-07-17 13:32   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BF8F53.1040701@st.com \
    --to=maxime.coquelin-qxv4g6hh51o@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).