[PATCH] i2c: i2c-st: Use %pa to print 'resource_size_t' type

[PATCH] i2c: i2c-st: Use %pa to print 'resource_size_t' type

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
is seen:

drivers/i2c/busses/i2c-st.c:818:2: warning: format '%x' expects argument of type
'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat=]

Use %pa to print 'resource_size_t' type to fix the warning.

Reported-by: Olof's autobuilder <build-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/i2c/busses/i2c-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
index 95b94767..fc767dd 100644
--- a/drivers/i2c/busses/i2c-st.c
+++ b/drivers/i2c/busses/i2c-st.c
@@ -815,7 +815,7 @@ static int st_i2c_probe(struct platform_device *pdev)
 
 	adap = &i2c_dev->adap;
 	i2c_set_adapdata(adap, i2c_dev);
-	snprintf(adap->name, sizeof(adap->name), "ST I2C(0x%x)", res->start);
+	snprintf(adap->name, sizeof(adap->name), "ST I2C(0x%pa)", &res->start);
 	adap->owner = THIS_MODULE;
 	adap->timeout = 2 * HZ;
 	adap->retries = 0;
-- 
1.8.3.2

Re: [PATCH] i2c: i2c-st: Use %pa to print 'resource_size_t' type

[Maxime Coquelin]

Hi Fabio,

On 07/11/2014 01:23 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
> is seen:
>
> drivers/i2c/busses/i2c-st.c:818:2: warning: format '%x' expects argument of type
> 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat=]
>
> Use %pa to print 'resource_size_t' type to fix the warning.
>
> Reported-by: Olof's autobuilder <build-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>   drivers/i2c/busses/i2c-st.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>

Thanks!
Maxime

>
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index 95b94767..fc767dd 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -815,7 +815,7 @@ static int st_i2c_probe(struct platform_device *pdev)
>
>   	adap = &i2c_dev->adap;
>   	i2c_set_adapdata(adap, i2c_dev);
> -	snprintf(adap->name, sizeof(adap->name), "ST I2C(0x%x)", res->start);
> +	snprintf(adap->name, sizeof(adap->name), "ST I2C(0x%pa)", &res->start);
>   	adap->owner = THIS_MODULE;
>   	adap->timeout = 2 * HZ;
>   	adap->retries = 0;
>

Re: [PATCH] i2c: i2c-st: Use %pa to print 'resource_size_t' type

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Thu, Jul 10, 2014 at 08:23:25PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
> is seen:
> 
> drivers/i2c/busses/i2c-st.c:818:2: warning: format '%x' expects argument of type
> 'unsigned int', but argument 4 has type 'resource_size_t' [-Wformat=]
> 
> Use %pa to print 'resource_size_t' type to fix the warning.
> 
> Reported-by: Olof's autobuilder <build-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Applied to for-current, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]