From: Maxime Coquelin <maxime.coquelin@st.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
Patrice Chotard <patrice.chotard@st.com>,
kernel@stlinux.com
Subject: Re: [PATCH] drivers: i2c: i2c-st: Update i2c timings
Date: Mon, 21 Jul 2014 13:05:16 +0200 [thread overview]
Message-ID: <53CCF3EC.6030904@st.com> (raw)
In-Reply-To: <20140603075922.GB2653@katana>
Hi Wolfram,
On 06/03/2014 09:59 AM, Wolfram Sang wrote:
>
>>> Can you give names here? Would be interesting to know since a few
>>> drivers implement the minimum timings.
>>
>> I don't have the name actually.
>> The request to implement this change came from hw guys.
>
> Can you ask? It feels better to have changes based on facts.
Sorry for the late reply, but it took time to get the answer.
Apparently the HDMI link of the Toshiba 19AV600U TV is affected by this.
I have no references of other devices (if any).
>
>>>> This patch adds a 10% margin on all the timings.
>>>
>>> Is there a safety margin or do the devices start to work exactly at 10%?
>>
>> 10% is a safety margin, I don't know what is the limit.
>
> Which also came from the HW guys? Please ask for details why 10%, too.
This is a safety margin.
Note that the I2C specification only defines minimal timings.
Is it fine for you?
Can I re-send a v2, which:
- Indicate the Toshiba TV is one of the affected devices in the commit message
- Indicate the 10% margin is a safety one in the commit message
- Add a comment above the table indicating these are standard timings + 10% margin.
Regards,
Maxime
>
> Thanks,
>
> Wolfram
>
next prev parent reply other threads:[~2014-07-21 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:32 [PATCH] drivers: i2c: i2c-st: Update i2c timings Maxime COQUELIN
2014-06-02 16:31 ` Wolfram Sang
2014-06-03 7:32 ` Maxime Coquelin
[not found] ` <538D7A1C.5040409-qxv4g6HH51o@public.gmane.org>
2014-06-03 7:59 ` Wolfram Sang
2014-07-21 11:05 ` Maxime Coquelin [this message]
[not found] ` <53CCF3EC.6030904-qxv4g6HH51o@public.gmane.org>
2014-07-21 14:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CCF3EC.6030904@st.com \
--to=maxime.coquelin@st.com \
--cc=kernel@stlinux.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=srinivas.kandagatla@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).