From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan Tianyu Subject: Re: [PATCH] I2C: Make I2C core able to be module when I2C_ACPI is selected. Date: Wed, 13 Aug 2014 10:50:32 +0800 Message-ID: <53EAD278.2010003@intel.com> References: <1407740455-21269-1-git-send-email-tianyu.lan@intel.com> <20140812095321.GU1657@lahna.fi.intel.com> <20140813020250.GA2853@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140813020250.GA2853@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang , Mika Westerberg Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On 2014=E5=B9=B408=E6=9C=8813=E6=97=A5 10:03, Wolfram Sang wrote: > On Tue, Aug 12, 2014 at 12:53:21PM +0300, Mika Westerberg wrote: >> On Mon, Aug 11, 2014 at 03:00:55PM +0800, Lan Tianyu wrote: >>> Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C= _ACPI >>> config) adds a new kernel config I2C_ACPI and make I2C core built i= n >>> when the config is selected. This is wrong because distributions >>> etc generally compile I2C as a module and the commit broken that. >>> This patch is to make I2C core able to be a module when I2C_ACPI is >>> selected. Original issue the commit da3c6647 tried to avoid will >>> be fixed in ACPICA and it's rarely triggered during unloading modul= e.=20 >>> >>> Signed-off-by: Lan Tianyu >> >> I wonder if we can do >> >> depends on I2C=3Dy >> >> here? If I understand it right, then we only build the ACPI_I2C if I= 2C >> is compiled into the kernel. That way the problem da3c6647 tried to >> solve doens't re-appear. >> >> We can later on relax this once ACPICA has been fixed. Thoughts? >=20 > I had the same idea yet my travel to Chicago interrupted thinking abo= ut > it further. Once I get rid of my jetlag, I'll have a closer look. Unl= ess > you already came up with the perfect solution until then, of course ;= ) > Hi Mika & Wolfram: I have one concern about "depends on I2C=3Dy". If distribution config file selects I2C core as a module, the original code can enumerate I2C slave devices from ACPI table. But now I2C_ACPI depends on I2C core built in, the I2C module can't enumerate devices from ACPI table. This maybe a regression for distribution? --=20 Best regards Tianyu Lan