From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C Date: Thu, 21 Aug 2014 11:18:56 +0900 Message-ID: <53F55710.8000702@samsung.com> References: <1408270138-29811-1-git-send-email-geert@linux-m68k.org> <1408270138-29811-2-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <1408270138-29811-2-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Mark Brown , Greg Kroah-Hartman , MyungJoo Ham , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Geert Thanks for your report. I already sent a patch[1] to fix this build bre= ak and I'll send pull request to includec this patch in 3.17-rc2. [1] https://lkml.org/lkml/2014/8/13/761 Best Regards, Chanwoo Choi On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote: > EXTCON_SM5502 selects REGMAP_I2C, but if I2C=3Dn: >=20 > drivers/base/regmap/regmap-i2c.c: In function =E2=80=98regmap_smbus_b= yte_reg_read=E2=80=99: > drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of f= unction =E2=80=98i2c_smbus_read_byte_data=E2=80=99 > drivers/base/regmap/regmap-i2c.c: In function =E2=80=98regmap_smbus_b= yte_reg_write=E2=80=99: > drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of f= unction =E2=80=98i2c_smbus_write_byte_data=E2=80=99 > drivers/base/regmap/regmap-i2c.c: In function =E2=80=98regmap_smbus_w= ord_reg_read=E2=80=99: > drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of f= unction =E2=80=98i2c_smbus_read_word_data=E2=80=99 > drivers/base/regmap/regmap-i2c.c: In function =E2=80=98regmap_smbus_w= ord_reg_write=E2=80=99: > drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of f= unction =E2=80=98i2c_smbus_write_word_data=E2=80=99 > drivers/base/regmap/regmap-i2c.c: In function =E2=80=98regmap_i2c_wri= te=E2=80=99: > drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of f= unction =E2=80=98i2c_master_send=E2=80=99 > drivers/base/regmap/regmap-i2c.c: In function =E2=80=98regmap_i2c_gat= her_write=E2=80=99: > drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of = function =E2=80=98i2c_check_functionality=E2=80=99 > drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of = function =E2=80=98i2c_transfer=E2=80=99 >=20 > Signed-off-by: Geert Uytterhoeven > --- > drivers/extcon/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index 6f2f4727de2c..764f3a113e0a 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -72,6 +72,7 @@ config EXTCON_PALMAS > =20 > config EXTCON_SM5502 > tristate "SM5502 EXTCON support" > + depends on I2C > select IRQ_DOMAIN > select REGMAP_I2C > select REGMAP_IRQ >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html