From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Addy Ke <addy.ke@rock-chips.com>,
wsa@the-dreams.de, max.schwarz@online.de, heiko@sntech.de,
olof@lixom.net, dianders@chromium.org
Cc: huangtao@rock-chips.com, hl@rock-chips.com, yzq@rock-chips.com,
zyw@rock-chips.com, linux-kernel@vger.kernel.org,
kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org,
xjq@rock-chips.com, linux-i2c@vger.kernel.org,
caesar.wang@rock-chips.com, cf@rock-chips.com, hj@rock-chips.com,
zhengsq@rock-chips.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: rk3x: fix bug that cause transfer fails in master receive mode
Date: Thu, 21 Aug 2014 22:04:31 +0400 [thread overview]
Message-ID: <53F634AF.1010303@cogentembedded.com> (raw)
In-Reply-To: <1408643457-7126-1-git-send-email-addy.ke@rock-chips.com>
Hello.
On 08/21/2014 09:50 PM, Addy Ke wrote:
> In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data
> in one transaction, so the size of data to be write/read to/from
> TXDATAx/RXDATAx must be less than or equal 32 bytes at a time.
> Test on pinky board, elan receive 158 bytes data.
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
> ---
> drivers/i2c/busses/i2c-rk3x.c | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 69e1185..dc0aa64 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -323,6 +323,9 @@ static void rk3x_i2c_handle_read(struct rk3x_i2c *i2c, unsigned int ipd)
> /* ack interrupt */
> i2c_writel(i2c, REG_INT_MBRF, REG_IPD);
>
> + /* Can only handle a maximum of 32 bytes at a time */
> + len = (len > 32) ? 32 : len;
Why not min(len, 32)? Or even:
if (len > 32)
len = 32;
WBR, Sergei
next prev parent reply other threads:[~2014-08-21 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 17:50 [PATCH] i2c: rk3x: fix bug that cause transfer fails in master receive mode Addy Ke
2014-08-21 18:04 ` Sergei Shtylyov [this message]
[not found] ` <53F634AF.1010303-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-08-21 18:17 ` Wolfram Sang
2014-08-21 18:54 ` Max Schwarz
2014-08-21 20:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F634AF.1010303@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=addy.ke@rock-chips.com \
--cc=caesar.wang@rock-chips.com \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=hj@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=max.schwarz@online.de \
--cc=olof@lixom.net \
--cc=wsa@the-dreams.de \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhengsq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).