From: "Heiko Stübner" <heiko@sntech.de>
To: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Jean Delvare" <jdelvare@suse.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Ludovic Desroches" <ludovic.desroches@atmel.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Jon Mason" <jonmason@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Sonic Zhang" <sonic.zhang@analog.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"Gregory Fong" <gregory.0xf0@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Jochen Friedrich" <jochen@scram.de>,
"Sekhar Nori" <nsekhar@ti.com>,
"Kevin Hilman" <khilman@kernel.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Uwe Kleine-König" <kernel@pengutronix.de>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>
Subject: Re: [PATCH] i2c: don't print error when adding adapter fails
Date: Tue, 09 Aug 2016 14:13:11 +0200 [thread overview]
Message-ID: <5423570.keugkegXM3@diego> (raw)
In-Reply-To: <1470742581-12971-2-git-send-email-wsa-dev@sang-engineering.com>
Am Dienstag, 9. August 2016, 13:36:17 schrieb Wolfram Sang:
> The core will do this for us now.
>
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
> ---
[...]
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 2bc8b01153d619..3b87afe82f6394 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -1303,10 +1303,8 @@ static int rk3x_i2c_probe(struct platform_device
> *pdev) rk3x_i2c_adapt_div(i2c, clk_rate);
>
> ret = i2c_add_adapter(&i2c->adap);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "Could not register adapter\n");
> + if (ret < 0)
> goto err_clk_notifier;
> - }
>
> dev_info(&pdev->dev, "Initialized RK3xxx I2C bus at %p\n", i2c->regs);
for Rockchip
Acked-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2016-08-09 12:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:36 [PATCH] i2c: don't print error when adding adapter fails Wolfram Sang
[not found] ` <1470742581-12971-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:57 ` Uwe Kleine-König
2016-08-09 13:59 ` Wolfram Sang
2016-08-09 12:13 ` Heiko Stübner [this message]
2016-08-09 12:55 ` Neil Horman
[not found] ` <20160809125522.GA15676-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2016-08-10 2:56 ` Zhang, Sonic
2016-08-09 13:31 ` Guenter Roeck
2016-08-09 14:39 ` Wolfram Sang
[not found] ` <1470742581-12971-2-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
2016-08-09 11:47 ` Grygorii Strashko
2016-08-09 11:48 ` Peter Korsgaard
2016-08-09 12:58 ` Thierry Reding
2016-08-09 16:15 ` Ray Jui
2016-08-10 6:17 ` Ludovic Desroches
2016-08-10 8:34 ` Laxman Dewangan
2016-10-05 15:17 ` Jean Delvare
2016-08-09 16:36 ` Vladimir Zapolskiy
2016-08-10 8:32 ` Krzysztof Kozlowski
2016-08-09 16:45 ` Joachim Eastwood
2016-08-10 6:50 ` [STLinux Kernel] " Patrice Chotard
2016-08-14 22:17 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5423570.keugkegXM3@diego \
--to=heiko@sntech.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=jdelvare@suse.com \
--cc=jochen@scram.de \
--cc=jonmason@broadcom.com \
--cc=k.kozlowski@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ludovic.desroches@atmel.com \
--cc=michal.simek@xilinx.com \
--cc=nsekhar@ti.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sonic.zhang@analog.com \
--cc=soren.brinkmann@xilinx.com \
--cc=wsa-dev@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).