From: Dmitry Osipenko <digetx@gmail.com>
To: LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@microchip.com>
Cc: UNGLinuxDriver@microchip.com, wsa@kernel.org,
andriy.shevchenko@linux.intel.com, treding@nvidia.com,
mirq-linux@rere.qmqm.pl, s.shtylyov@omp.ru,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] i2c:busses:Register PCI1XXXX adapter to I2C subsystem
Date: Thu, 7 Oct 2021 19:30:55 +0300 [thread overview]
Message-ID: <5493f2ea-4e5a-3917-4fee-08d8ef0511b5@gmail.com> (raw)
In-Reply-To: <683a7136ec818d01420a5c2cbf43e13498d82740.camel@microchip.com>
05.10.2021 11:50, LakshmiPraveen Kopparthi пишет:
>> Interrupt is disabled in ISR, this lock does nothing.
>
> Ok. But there are some registers that are read and updated in the ISR
> and in the foreground.
> I will add the lock for these register access.
Please either add everything into a single patch or remove the unused code.
If you will need to add a lock, then like Michał Mirosław suggested in
the other reply, you won't need to store/restore IRQ flags in the
interrupt context.
next prev parent reply other threads:[~2021-10-07 16:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 6:22 [PATCH v1 0/2] i2c:busses:Microchip PCI1XXXX I2C adapter LakshmiPraveen Kopparthi
2021-09-29 6:22 ` [PATCH v1 1/2] i2c:busses:Register PCI1XXXX adapter to I2C subsystem LakshmiPraveen Kopparthi
2021-09-29 7:18 ` Dmitry Osipenko
2021-09-29 14:35 ` Dmitry Osipenko
2021-10-05 8:49 ` LakshmiPraveen Kopparthi
2021-09-29 16:44 ` Andy Shevchenko
2021-10-05 8:49 ` LakshmiPraveen Kopparthi
2021-10-05 8:50 ` LakshmiPraveen Kopparthi
2021-10-07 16:24 ` Dmitry Osipenko
2021-10-07 16:33 ` Andy Shevchenko
2021-10-07 16:30 ` Dmitry Osipenko [this message]
2021-09-29 17:12 ` Michał Mirosław
2021-10-08 6:22 ` LakshmiPraveen Kopparthi
2021-10-07 16:40 ` Dmitry Osipenko
2021-10-07 17:05 ` Andy Shevchenko
2021-09-29 6:22 ` [PATCH v1 2/2] i2c:busses:Read and Write routines for PCI1XXXX I2C module LakshmiPraveen Kopparthi
2021-09-29 7:20 ` Dmitry Osipenko
2021-10-05 8:48 ` LakshmiPraveen Kopparthi
2021-10-07 16:15 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5493f2ea-4e5a-3917-4fee-08d8ef0511b5@gmail.com \
--to=digetx@gmail.com \
--cc=LakshmiPraveen.Kopparthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=s.shtylyov@omp.ru \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).