linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jean Delvare <khali@linux-fr.org>,
	Boaz Harrosh <boaz@plexistor.com>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Rui Wang <ruiv.wang@gmail.com>, Alun Evans <alun@badgerous.net>,
	Robert Elliott <Elliott@hp.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Tony Luck <tony.luck@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips
Date: Sun, 08 Mar 2015 12:50:31 -0700	[thread overview]
Message-ID: <54FCA807.7080505@roeck-us.net> (raw)
In-Reply-To: <CALCETrUYwvF6cbmGy4zU-HNYe7xamw61+7nuryN0KaRdS7i24A@mail.gmail.com>

On 03/08/2015 12:30 PM, Andy Lutomirski wrote:
[ ... ]

>>
>>> One other question: from my reading of the spec, it should be possible to
>>> augment this driver to expose a temporate sensor subdevice that shows
>>> recent cached temperatures from HW DIMM measurements.  They would be
>>> redundant with the jc42 outputs, but it would be safe to use them even on
>>> systems without safe SMBUS arbitration.  Should I do that as a followup
>>> later on?
>>>
>>
>> Without thinking too much about it, this should be a separate driver,
>> and I think it might actually be more valuable (since less risky)
>> than this entire patch set.
>
> The main problem there is that they'll fight over the PCI ids.
>
That is why we have mfd drivers. While that most likely won't be a
solution here (and I don't suggest it), you can use the same idea.
If can not be instantiated as pci driver, the alternative would be
to instantiate it as platform driver and let it get its pci
information from the parent device.

Guenter

  reply	other threads:[~2015-03-08 19:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07  2:50 [PATCH 0/2] i2c_imc: New driver, at long last Andy Lutomirski
2015-03-07  2:50 ` [PATCH 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips Andy Lutomirski
     [not found]   ` <13443f0542fb447a4c0e558a5f6077c6a76a6e95.1425695891.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2015-03-07 12:48     ` Paul Bolle
2015-03-07 14:38   ` Guenter Roeck
2015-03-08 14:03     ` Andy Lutomirski
2015-03-08 15:39       ` Guenter Roeck
     [not found]         ` <54FC6D2B.3060307-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-08 19:30           ` Andy Lutomirski
2015-03-08 19:50             ` Guenter Roeck [this message]
     [not found]               ` <54FCA807.7080505-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-08 19:55                 ` Andy Lutomirski
2015-03-07  2:50 ` [PATCH 2/2] i2c, i2c_imc: Add DIMM bus code Andy Lutomirski
     [not found]   ` <4ec9e7471354b350936ffa75e94125b169d14690.1425695891.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2015-03-07 12:51     ` Paul Bolle
2015-03-07 16:03   ` Guenter Roeck
     [not found]     ` <54FB2154.7000701-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-08 14:09       ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FCA807.7080505@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Elliott@hp.com \
    --cc=alun@badgerous.net \
    --cc=boaz@plexistor.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=khali@linux-fr.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=m.chehab@samsung.com \
    --cc=ruiv.wang@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).