* [PATCH] i2c: st: add include for pinctrl
@ 2015-04-23 11:42 Wolfram Sang
[not found] ` <1429789322-27260-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2015-04-23 11:42 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Maxime Coquelin, Wolfram Sang, Pascal Huerst
The driver uses pinctrl directly and thus should include the appropriate
header. Sort the headers while we are here to have a better view what is
included and what is not.
Reported-by: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
drivers/i2c/busses/i2c-st.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
index 88057fad9dfef4..d525769db5c3d5 100644
--- a/drivers/i2c/busses/i2c-st.c
+++ b/drivers/i2c/busses/i2c-st.c
@@ -10,17 +10,18 @@
* published by the Free Software Foundation.
*/
-#include <linux/module.h>
-#include <linux/platform_device.h>
-#include <linux/i2c.h>
#include <linux/clk.h>
-#include <linux/io.h>
#include <linux/delay.h>
-#include <linux/interrupt.h>
#include <linux/err.h>
-#include <linux/of.h>
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/module.h>
#include <linux/of_address.h>
+#include <linux/of.h>
#include <linux/of_irq.h>
+#include <linux/pinctrl/consumer.h>
+#include <linux/platform_device.h>
/* SSC registers */
#define SSC_BRG 0x000
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: st: add include for pinctrl
[not found] ` <1429789322-27260-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
@ 2015-04-23 16:33 ` Wolfram Sang
2015-04-29 12:00 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2015-04-23 16:33 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Maxime Coquelin, Pascal Huerst
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Thu, Apr 23, 2015 at 01:42:02PM +0200, Wolfram Sang wrote:
> The driver uses pinctrl directly and thus should include the appropriate
> header. Sort the headers while we are here to have a better view what is
> included and what is not.
>
> Reported-by: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Improved the sorting some more and applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: st: add include for pinctrl
2015-04-23 16:33 ` Wolfram Sang
@ 2015-04-29 12:00 ` Maxime Coquelin
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2015-04-29 12:00 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Pascal Huerst
On 04/23/2015 06:33 PM, Wolfram Sang wrote:
> On Thu, Apr 23, 2015 at 01:42:02PM +0200, Wolfram Sang wrote:
>> The driver uses pinctrl directly and thus should include the appropriate
>> header. Sort the headers while we are here to have a better view what is
>> included and what is not.
>>
>> Reported-by: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> Improved the sorting some more and applied to for-current, thanks!
>
Thanks Wolfram.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-29 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-23 11:42 [PATCH] i2c: st: add include for pinctrl Wolfram Sang
[not found] ` <1429789322-27260-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-04-23 16:33 ` Wolfram Sang
2015-04-29 12:00 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).