From: Kukjin Kim <kgene@kernel.org>
To: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms
Date: Wed, 06 May 2015 06:30:42 +0900 [thread overview]
Message-ID: <55493682.6040309@kernel.org> (raw)
In-Reply-To: <55493607.3070400@kernel.org>
On 05/06/15 06:28, Kukjin Kim wrote:
> On 05/04/15 08:50, Krzysztof Kozlowski wrote:
>> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul@gmail.com>:
>>> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>>>
>>> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
>>
>> I think the crash is possible if device node is missing in DT or pdata
>> is supplied. If you agree, could you add this information to commit
>> message, along with Cc-stable and Fixes tag?
>>
>> Anyway, the patch itself looks good:
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
> Can you please add me in Cc in your next posting?
>
> I can't see the patch in my mail box...
>
Oops, sorry for the noise. My email client had a problem and I can see
the patch now. Please kindly ignore the request :)
Thanks,
Kukjin
next prev parent reply other threads:[~2015-05-05 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 18:13 [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms Vasily Khoruzhick
2015-05-03 23:50 ` Krzysztof Kozlowski
[not found] ` <CAJKOXPd71vnup-RZYAh7UM2Tky2M64tA=u0Ydy=ti0yOC6h5aQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-04 17:52 ` Vasily Khoruzhick
[not found] ` <CA+E=qVdjvx=0PSh-ead_pABd9D=bG3ua1FFRTSN2U5BVf2a=Og-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-05 1:46 ` Krzysztof Kozlowski
2015-05-05 21:28 ` Kukjin Kim
2015-05-05 21:30 ` Kukjin Kim [this message]
[not found] ` <1430676790-30500-1-git-send-email-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-12 16:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55493682.6040309@kernel.org \
--to=kgene@kernel.org \
--cc=anarsoul@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).