[PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Vasily Khoruzhick]

Initialize sysreg by default, otherwise driver will crash in suspend callback.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 drivers/i2c/busses/i2c-s3c2410.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 958c8db..297e9c9 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1143,6 +1143,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	i2c->quirks = s3c24xx_get_device_quirks(pdev);
+	i2c->sysreg = ERR_PTR(-ENOENT);
 	if (pdata)
 		memcpy(i2c->pdata, pdata, sizeof(*pdata));
 	else
-- 
2.3.5

Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Krzysztof Kozlowski]

2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul@gmail.com>:
> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

I think the crash is possible if device node is missing in DT or pdata
is supplied. If you agree, could you add this information to commit
message, along with Cc-stable and Fixes tag?

Anyway, the patch itself looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Vasily Khoruzhick]

On Mon, May 4, 2015 at 2:50 AM, Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>>
>> Signed-off-by: Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> I think the crash is possible if device node is missing in DT or pdata
> is supplied.

And it's exactly the case for non-DT boot, right?

> If you agree, could you add this information to commit
> message, along with Cc-stable and Fixes tag?

How do I add "Fixes tag"?

> Anyway, the patch itself looks good:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Best regards,
> Krzysztof

Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Krzysztof Kozlowski]

2015-05-05 2:52 GMT+09:00 Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> On Mon, May 4, 2015 at 2:50 AM, Krzysztof Kozlowski
> <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>>>
>>> Signed-off-by: Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> I think the crash is possible if device node is missing in DT or pdata
>> is supplied.
>
> And it's exactly the case for non-DT boot, right?

Right, please add this to commit message.

>
>> If you agree, could you add this information to commit
>> message, along with Cc-stable and Fixes tag?
>
> How do I add "Fixes tag"?

In tbe commit message just add below Signed-off-by:
1. Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
2. Fixes: abbreviated SHA ("commit subject")
The SHA of commit which introduced this error. It indicates how far
your patch should be backported.

Look for examples in kernel GIT and
Documentation/stable_kernel_rules.txt. For example:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1c363c7cccf64128087002b0779986ad16aff6dc

Best regards,
Krzysztof

Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Kukjin Kim]

On 05/04/15 08:50, Krzysztof Kozlowski wrote:
> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>>
>> Signed-off-by: Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> I think the crash is possible if device node is missing in DT or pdata
> is supplied. If you agree, could you add this information to commit
> message, along with Cc-stable and Fixes tag?
> 
> Anyway, the patch itself looks good:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> 
Can you please add me in Cc in your next posting?

I can't see the patch in my mail box...

- Kukjin

Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Kukjin Kim]

On 05/06/15 06:28, Kukjin Kim wrote:
> On 05/04/15 08:50, Krzysztof Kozlowski wrote:
>> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick <anarsoul@gmail.com>:
>>> Initialize sysreg by default, otherwise driver will crash in suspend callback.
>>>
>>> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
>>
>> I think the crash is possible if device node is missing in DT or pdata
>> is supplied. If you agree, could you add this information to commit
>> message, along with Cc-stable and Fixes tag?
>>
>> Anyway, the patch itself looks good:
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
> Can you please add me in Cc in your next posting?
> 
> I can't see the patch in my mail box...
> 
Oops, sorry for the noise. My email client had a problem and I can see
the patch now. Please kindly ignore the request :)

Thanks,
Kukjin

Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

On Sun, May 03, 2015 at 09:13:10PM +0300, Vasily Khoruzhick wrote:
> Initialize sysreg by default, otherwise driver will crash in suspend callback.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Applied to for-current, thanks!
Added stable and the fixes tag, too.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]