From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms Date: Wed, 06 May 2015 06:30:42 +0900 Message-ID: <55493682.6040309@kernel.org> References: <1430676790-30500-1-git-send-email-anarsoul@gmail.com> <55493607.3070400@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55493607.3070400@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Kukjin Kim Cc: Krzysztof Kozlowski , Vasily Khoruzhick , Wolfram Sang , linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 05/06/15 06:28, Kukjin Kim wrote: > On 05/04/15 08:50, Krzysztof Kozlowski wrote: >> 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick : >>> Initialize sysreg by default, otherwise driver will crash in suspend callback. >>> >>> Signed-off-by: Vasily Khoruzhick >> >> I think the crash is possible if device node is missing in DT or pdata >> is supplied. If you agree, could you add this information to commit >> message, along with Cc-stable and Fixes tag? >> >> Anyway, the patch itself looks good: >> Reviewed-by: Krzysztof Kozlowski >> > Can you please add me in Cc in your next posting? > > I can't see the patch in my mail box... > Oops, sorry for the noise. My email client had a problem and I can see the patch now. Please kindly ignore the request :) Thanks, Kukjin