linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: zhangfei <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>,
	Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Wei Yan <sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work
Date: Fri, 08 May 2015 22:56:59 +0800	[thread overview]
Message-ID: <554CCEBB.6000107@linaro.org> (raw)
In-Reply-To: <1431046211.31122.1.camel-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>



On 05/08/2015 08:50 AM, Axel Lin wrote:
> Make the modalias match driver name, this is required to make module
> auto-loading work.
>
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>

Thanks Axel

Could you also share the info what's the condition of auto-loading module.

What I am test here is change the names works.
-               .name   = "hix5hd2-i2c",
+               .name   = "i2c-hix5hd2",

Change MODULE_ALIAS("platform:hix5hd2-i2c") does not works here.
Do I make some mistake?

> ---
>   drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
> index 8fe78d0..7c696643 100644
> --- a/drivers/i2c/busses/i2c-hix5hd2.c
> +++ b/drivers/i2c/busses/i2c-hix5hd2.c
> @@ -554,4 +554,4 @@ module_platform_driver(hix5hd2_i2c_driver);
>   MODULE_DESCRIPTION("Hix5hd2 I2C Bus driver");
>   MODULE_AUTHOR("Wei Yan <sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:i2c-hix5hd2");
> +MODULE_ALIAS("platform:hix5hd2-i2c");
>

  parent reply	other threads:[~2015-05-08 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08  0:50 [PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work Axel Lin
     [not found] ` <1431046211.31122.1.camel-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
2015-05-08 14:56   ` zhangfei [this message]
     [not found]     ` <554CCEBB.6000107-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-08 15:21       ` Axel Lin
2015-05-11  4:09   ` Zhangfei Gao
2015-05-12 16:10   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554CCEBB.6000107@linaro.org \
    --to=zhangfei.gao-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).