[PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work

[PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work

[Axel Lin]

Make the modalias match driver name, this is required to make module
auto-loading work.

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
index 8fe78d0..7c696643 100644
--- a/drivers/i2c/busses/i2c-hix5hd2.c
+++ b/drivers/i2c/busses/i2c-hix5hd2.c
@@ -554,4 +554,4 @@ module_platform_driver(hix5hd2_i2c_driver);
 MODULE_DESCRIPTION("Hix5hd2 I2C Bus driver");
 MODULE_AUTHOR("Wei Yan <sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:i2c-hix5hd2");
+MODULE_ALIAS("platform:hix5hd2-i2c");
-- 
2.1.0

Re: [PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work

[zhangfei]

On 05/08/2015 08:50 AM, Axel Lin wrote:
> Make the modalias match driver name, this is required to make module
> auto-loading work.
>
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>

Thanks Axel

Could you also share the info what's the condition of auto-loading module.

What I am test here is change the names works.
-               .name   = "hix5hd2-i2c",
+               .name   = "i2c-hix5hd2",

Change MODULE_ALIAS("platform:hix5hd2-i2c") does not works here.
Do I make some mistake?

> ---
>   drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
> index 8fe78d0..7c696643 100644
> --- a/drivers/i2c/busses/i2c-hix5hd2.c
> +++ b/drivers/i2c/busses/i2c-hix5hd2.c
> @@ -554,4 +554,4 @@ module_platform_driver(hix5hd2_i2c_driver);
>   MODULE_DESCRIPTION("Hix5hd2 I2C Bus driver");
>   MODULE_AUTHOR("Wei Yan <sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:i2c-hix5hd2");
> +MODULE_ALIAS("platform:hix5hd2-i2c");
>

Re: [PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work

[Axel Lin]

2015-05-08 22:56 GMT+08:00 zhangfei <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>:
>
>
> On 05/08/2015 08:50 AM, Axel Lin wrote:
>>
>> Make the modalias match driver name, this is required to make module
>> auto-loading work.
>>
>> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
>
>
> Thanks Axel
>
> Could you also share the info what's the condition of auto-loading module.
>
> What I am test here is change the names works.
> -               .name   = "hix5hd2-i2c",
> +               .name   = "i2c-hix5hd2",
>
> Change MODULE_ALIAS("platform:hix5hd2-i2c") does not works here.
> Do I make some mistake?

The driver name needs to match the platform device name.
I have no idea why you change the driver name and it still work.

In drivers/base/platform.c, the platform_uevent sends uevenet with
MODALIAS=platform:pdev->name. so the MODULE_ALIAS needs to match pdev->name.
Maybe forgot running depmod -a?

Re: [PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work

[Zhangfei Gao]

On 8 May 2015 at 08:50, Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org> wrote:
> Make the modalias match driver name, this is required to make module
> auto-loading work.
>
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>

Acked-by: Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Thanks for the patch,
Also checked MODULE_ALIAS notes in Documentation/i2c/writing-clients.

> ---
>  drivers/i2c/busses/i2c-hix5hd2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
> index 8fe78d0..7c696643 100644
> --- a/drivers/i2c/busses/i2c-hix5hd2.c
> +++ b/drivers/i2c/busses/i2c-hix5hd2.c
> @@ -554,4 +554,4 @@ module_platform_driver(hix5hd2_i2c_driver);
>  MODULE_DESCRIPTION("Hix5hd2 I2C Bus driver");
>  MODULE_AUTHOR("Wei Yan <sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>");
>  MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:i2c-hix5hd2");
> +MODULE_ALIAS("platform:hix5hd2-i2c");
> --
> 2.1.0
>
>
>

Re: [PATCH] i2c: hix5hd2: Fix modalias to make module auto-loading work

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

On Fri, May 08, 2015 at 08:50:11AM +0800, Axel Lin wrote:
> Make the modalias match driver name, this is required to make module
> auto-loading work.
> 
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>

Applied to for-current, thanks!
Added stable, too.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]