linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Lawnick <michael.lawnick-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: "ext Uwe Kleine-König"
	<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"Michael Lawnick" <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	Alexander Sverdlin
	<alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
	Nicholas Mc Guire
	<hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>,
	Anders Berg <anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Wilshire Jay
	<jay.wilshire.ext-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i2c: axxia: Add bus recovery functionality
Date: Wed, 13 May 2015 09:20:48 +0200	[thread overview]
Message-ID: <5552FB50.4000409@nokia.com> (raw)
In-Reply-To: <20150513065549.GG28888-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Am 13.05.2015 um 08:55 schrieb ext Uwe Kleine-König:
> On Wed, May 13, 2015 at 08:19:59AM +0200, Michael Lawnick wrote:
>> Am 12.05.2015 um 21:12 schrieb Wolfram Sang:
>>> Doesn't look right. -EAGAIN means arbitration lost which is not a
>>> condition to reset the bus in a multi-master setup.
>>
>> IMHO in multi-master scenario bus recovery is never save. There is
>> need of higher level synchronization to find out whether any master
>> is active.
> Right. But you might be lucky and it's ok when done on error conditions
> like "sda is low since 300 ms". But on arbitration loss it's definitely
> wrong. Consider two masters where one resets the bus while the other
> does a transfer. That results in a arbitration loss for the latter. So
> the latter resets the bus and in the meantime the first one does a transfer
> now that the bus should be free. You see the loop?

Of course.
The question is: do/can controllers properly distinguish between 
arbitration loss and permanent SDL low? I always worked with single 
master assumption in last 10 years and /feel/ /to/ /remember/ to have 
observed situations were bus lock was signaled as arbitration loss.

I'm simply in doubt that multi master can be handled at driver level at 
all. This might mean in consequence that unlocking the bus should not be 
done automatically, but by an extra I2C method triggered by application 
level.
-- 
JM2C
Michael

  parent reply	other threads:[~2015-05-13  7:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 12:20 [PATCH] i2c: axxia: Add bus recovery functionality Alexander Sverdlin
     [not found] ` <553F7B11.5000204-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-05-12 19:12   ` Wolfram Sang
     [not found]     ` <20150512191211.GC4449-oo5tB6JMkjKRinMKxDlMNPwbnWRJjS81@public.gmane.org>
2015-05-13  6:19       ` Michael Lawnick
     [not found]         ` <5552ED0F.7000200-Mmb7MZpHnFY@public.gmane.org>
2015-05-13  6:55           ` Uwe Kleine-König
     [not found]             ` <20150513065549.GG28888-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-05-13  7:20               ` Michael Lawnick [this message]
     [not found]                 ` <5552FB50.4000409-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-05-13  7:54                   ` Uwe Kleine-König
2015-05-13  8:26       ` Alexander Sverdlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5552FB50.4000409@nokia.com \
    --to=michael.lawnick-xnzwkgviw5gavxtiumwx3w@public.gmane.org \
    --cc=alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org \
    --cc=hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org \
    --cc=jay.wilshire.ext-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ml.lawnick-Mmb7MZpHnFY@public.gmane.org \
    --cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).