From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1 1/1] i2c: designware-pci: clarify a comment for Merrifield
Date: Mon, 20 Jun 2016 09:47:15 +0300 [thread overview]
Message-ID: <555cf8c0-8e25-f839-1e7c-d6f2d083bfd9@linux.intel.com> (raw)
In-Reply-To: <1466367716-89939-1-git-send-email-andriy.shevchenko@linux.intel.com>
On 06/19/2016 11:21 PM, Andy Shevchenko wrote:
> There are more than 7 busses, but only 7 are user visible. Update comment
> accordingly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index b66c31a..7c5a340 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -125,10 +125,10 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
> static int mrfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
> {
> /*
> - * On Intel Merrifield the i2c busses are enumerated [1..7]. So, we add
> - * 1 to shift the default range. Besides that the first PCI slot
> - * provides 4 functions, that's why we have to add 0 to the head slot
> - * and 4 to the tail one.
> + * On Intel Merrifield the user visible i2c busses are enumerated
> + * [1..7]. So, we add 1 to shift the default range. Besides that the
> + * first PCI slot provides 4 functions, that's why we have to add 0 to
> + * the fisrt slot and 4 to the next one.
typo -> ---^
Otherwise
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
prev parent reply other threads:[~2016-06-20 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 20:21 [PATCH v1 1/1] i2c: designware-pci: clarify a comment for Merrifield Andy Shevchenko
2016-06-20 6:47 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555cf8c0-8e25-f839-1e7c-d6f2d083bfd9@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).