From: Alexander Sverdlin <alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: ext Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Kevin Hilman
<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC
Date: Thu, 18 Jun 2015 11:09:47 +0200 [thread overview]
Message-ID: <55828ADB.3080604@nokia.com> (raw)
In-Reply-To: <558288B0.1020706-l0cyMroinI0@public.gmane.org>
Hi!
On 18/06/15 11:00, ext Sekhar Nori wrote:
>> + if (davinci_i2c_read_reg(dev, DAVINCI_I2C_ICPID2_REG) == 0x2206) {
>> > + dev_dbg(dev->dev, "Keystone SoC detected\n");
>> > + d = 6;
>> > + }
> I think its better to use a different compatible string for i2c on
> keystone devices rather than using a fixed hardcoded IP version.
Yeah, this should have been done from the beginning, when the driver has been
re-used for Keystone, but this time is already missed, so I don't want
to introduce huge incompatibility with the existing device-trees.
And from the other PoV, device-trees are for something one cannot probe. We
can probe for Keystone revisions and can free the end-user from this headache
completely.
--
Best regards,
Alexander Sverdlin.
next prev parent reply other threads:[~2015-06-18 9:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 8:53 [PATCH] i2c: davinci: Fix bus rate calculation on Keystone SoC Alexander Sverdlin
[not found] ` <5582870B.7030304-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-06-18 9:00 ` Sekhar Nori
[not found] ` <558288B0.1020706-l0cyMroinI0@public.gmane.org>
2015-06-18 9:09 ` Alexander Sverdlin [this message]
[not found] ` <55828ADB.3080604-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-06-18 9:25 ` Sekhar Nori
[not found] ` <55828E7F.8060501-l0cyMroinI0@public.gmane.org>
2015-06-18 9:37 ` Alexander Sverdlin
[not found] ` <55829159.8050707-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-06-18 9:47 ` Sekhar Nori
[not found] ` <558293C9.9050904-l0cyMroinI0@public.gmane.org>
2015-06-18 10:04 ` Alexander Sverdlin
[not found] ` <558297B3.2060406-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-06-18 11:12 ` Sekhar Nori
[not found] ` <5582A7AF.5030000-l0cyMroinI0@public.gmane.org>
2015-06-18 11:30 ` Alexander Sverdlin
2015-06-18 16:22 ` Murali Karicheri
[not found] ` <5582F049.8070407-l0cyMroinI0@public.gmane.org>
2015-07-09 19:53 ` Wolfram Sang
2015-07-10 16:02 ` Sekhar Nori
[not found] ` <559FEC8C.9030603-l0cyMroinI0@public.gmane.org>
2015-07-10 18:26 ` Grygorii Strashko
[not found] ` <55A00E56.2020308-l0cyMroinI0@public.gmane.org>
2015-08-12 8:43 ` Wolfram Sang
2015-08-13 10:29 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55828ADB.3080604@nokia.com \
--to=alexander.sverdlin-xnzwkgviw5gavxtiumwx3w@public.gmane.org \
--cc=khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).