From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Sverdlin Subject: Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg Date: Thu, 18 Jun 2015 11:42:37 +0200 Message-ID: <5582928D.4080706@nokia.com> References: <1434475692-4611-1-git-send-email-yorksun@freescale.com> <1434531244.2069.111.camel@x220> <55818BAB.5090605@nokia.com> <1434556990.2400.16.camel@x220> <558275F1.5020100@nokia.com> <1434614901.2385.27.camel@x220> <5582899B.9030307@nokia.com> <1434619943.2385.59.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434619943.2385.59.camel@x220> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ext Paul Bolle Cc: York Sun , wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Korsgaard List-Id: linux-i2c@vger.kernel.org Hi! On 18/06/15 11:32, ext Paul Bolle wrote: > As I understand it, we've established that: > - this macro setups up udev, and modprobe, and friends, to listen to a > "MODALIAS=platform:i2c-mux-reg" message; and > - that there's currently no code in the kernel that will send out this > message. > > Did I get that right? Because it follows from the above that this line > serves no purpose. Worse, it makes the code actually confusing. Because Are you kidding? > it suggests the availability of functionality that in reality doesn't > exist. Most of the usual drivers in the Kernel have this line. Until now no animal was hurt with it. -- Best regards, Alexander Sverdlin.