From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Sverdlin Subject: Re: [PATCH 1/3] i2c: omap: switch to dev_get_drvdata() Date: Thu, 9 Jul 2015 12:09:01 +0200 Message-ID: <559E483D.1020206@nokia.com> References: <1435260890-32335-1-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435260890-32335-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ext Felipe Balbi Cc: Wolfram Sang , Linux OMAP Mailing List , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tony Lindgren , Linux ARM Kernel Mailing List List-Id: linux-i2c@vger.kernel.org Hi! On 25/06/15 21:34, ext Felipe Balbi wrote: > there's no need to fetch the platform_device > in order to dereference it back to the dev > pointer to access drvdata, we can use > dev_get_drvdata() instead. > > Signed-off-by: Felipe Balbi Acked-by: Alexander Sverdlin > --- > drivers/i2c/busses/i2c-omap.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 0e894193accf..00712c1cf3c0 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -1403,8 +1403,7 @@ static int omap_i2c_remove(struct platform_device *pdev) > #ifdef CONFIG_PM > static int omap_i2c_runtime_suspend(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct omap_i2c_dev *_dev = platform_get_drvdata(pdev); > + struct omap_i2c_dev *_dev = dev_get_drvdata(dev); > > _dev->iestate = omap_i2c_read_reg(_dev, OMAP_I2C_IE_REG); > > @@ -1428,8 +1427,7 @@ static int omap_i2c_runtime_suspend(struct device *dev) > > static int omap_i2c_runtime_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct omap_i2c_dev *_dev = platform_get_drvdata(pdev); > + struct omap_i2c_dev *_dev = dev_get_drvdata(dev); > > if (!_dev->regs) > return 0; -- Best regards, Alexander Sverdlin.