From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ellen Wang Subject: Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write Date: Tue, 14 Jul 2015 15:51:19 -0700 Message-ID: <55A59267.2020803@cumulusnetworks.com> References: <1436826234-2447-1-git-send-email-ellen@cumulusnetworks.com> <20150714114917.GG1517@katana> <20150714154939.GA20875@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150714154939.GA20875@katana> Sender: linux-input-owner@vger.kernel.org To: Wolfram Sang , Antonio Borneo Cc: Jiri Kosina , David Barksdale , linux-input , linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 07/14/2015 08:49 AM, Wolfram Sang wrote: > >> This is a MFD; should be split in GPIO and I2C, then each part moved >> in its respective tree. > > Yes, this is the conclusion we drew last time, too. It might seem > overkill for such simple devices, still this case shows how much drivers > can suffer if missing the expertise of the apropriate subsystem. That > being said, world is full of cornercases, I agree. This driver is a good example of that (missing expertise). It seems to be a fine HID driver but a lot of the I2C details were just wrong. At the same time, I have no idea whether the GPIO part works at all. >> Anyone already working in this direction? > > I'd be very surprised :) I could and would but I'm really not in a good position to do it. My only sample hardware is in a network switch.