From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: unmet direct dependencies in -next Date: Mon, 10 Aug 2015 13:24:00 +0200 Message-ID: <55C889D0.6060001@nod.at> References: <55C71FF5.1020902@nod.at> <20150810091004.GC3249@x1> <55C86B66.3020601@nod.at> <55C88738.80400@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55C88738.80400@suse.cz> Sender: linux-next-owner@vger.kernel.org To: Michal Marek , Lee Jones Cc: linux-next@vger.kernel.org, sameo@linux.intel.com, Arnd Bergmann , yann.morin.1998@free.fr, linux-kbuild , Wolfram Sang , "open list:I2C SUBSYSTEM" , user-mode-linux-devel List-Id: linux-i2c@vger.kernel.org Am 10.08.2015 um 13:12 schrieb Michal Marek: > On 2015-08-10 11:14, Richard Weinberger wrote: >> Am 10.08.2015 um 11:10 schrieb Lee Jones: >>> On Sun, 09 Aug 2015, Richard Weinberger wrote: >>> >>>> Hi! >>>> >>>> -next faces some build issues on UML because of unmet direct dependencies. >>>> Mostly due to HAS_IOMEM and I2C. >>>> >>>> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM) >>>> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && >>>> PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && >>>> HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM) >>>> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM) >>>> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && >>>> PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && >>>> HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM) >>>> >>>> For example MFD_SYSCON cannot build on UML as it depends on HAS_IOMEM. >>>> While the symbol MFD_SYSCON has correct dependencies some users of MFD_SYSCON >>>> just issue a "select MFD_SYSCON" and bypass the HAS_IOMEM dependency and causing the build to fail. >>>> >>>> This brings me to a question on kconfig itself, wouldn't it be better to just disable a symbol if it has >>>> unmet direct dependencies? > > The result of the given .config does not matter as much. The point of > the warnings is that there are missing select statements in the Kconfig > files. IMHO the situation could be improved. What about of failing hard "Your Kconfig is broken" or as I wrote disabling affected symbols? The current warning is something between. Kbuild detects that something is broken but produces a .config file. Thanks, //richard