From: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM framework
Date: Mon, 17 Aug 2015 14:01:24 +0100 [thread overview]
Message-ID: <55D1DB24.8090602@linaro.org> (raw)
In-Reply-To: <1511754934.28154.1439739426390.JavaMail.open-xchange-0SF9iQWekqLZ78VGacPtK8gmgJlYmuWJ@public.gmane.org>
+Adding Maxime in the loop
On 16/08/15 16:37, Stefan Wahren wrote:
>> >Another question which spring to mind is, do we want the eeprom to be
>> >in /sys twice, the old and the new way? Backwards compatibility says
>> >the old must stay. Do we want a way to suppress the new? Or should we
>> >be going as far as refractoring the code into a core library, and two
>> >wrapper drivers, old and new?
> I think these are questions for the framework maintainers.
>
One of the reasons for the NVMEM framework is to remove that duplicate
code in the every driver. There was no framework/ABI which was guiding
such old eeprom sysfs entry in first place, so I dont see an issue in
removing it for good. Correct me if am wrong.
IMHO, its better to move on with nvmem for good reasons, rather than
having two sysfs binary files.
--srini
next prev parent reply other threads:[~2015-08-17 13:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 2:54 [PATCH RFC] eeprom: at24: extend driver to plug into the NVMEM framework Andrew Lunn
[not found] ` <1439693649-10809-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2015-08-16 8:28 ` Stefan Wahren
2015-08-16 13:11 ` Andrew Lunn
[not found] ` <20150816131130.GC10094-g2DYL2Zd6BY@public.gmane.org>
2015-08-16 15:37 ` Stefan Wahren
[not found] ` <1511754934.28154.1439739426390.JavaMail.open-xchange-0SF9iQWekqLZ78VGacPtK8gmgJlYmuWJ@public.gmane.org>
2015-08-17 13:01 ` Srinivas Kandagatla [this message]
[not found] ` <55D1DB24.8090602-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-08-17 13:09 ` Andrew Lunn
[not found] ` <20150817130945.GE7537-g2DYL2Zd6BY@public.gmane.org>
2015-08-17 14:59 ` Srinivas Kandagatla
[not found] ` <55D1F6CB.2010606-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-08-17 15:25 ` Andrew Lunn
[not found] ` <20150817152504.GI7537-g2DYL2Zd6BY@public.gmane.org>
2015-08-17 15:41 ` Srinivas Kandagatla
2015-08-20 20:33 ` Wolfram Sang
2015-08-20 15:57 ` Maxime Ripard
2015-08-20 16:38 ` Andrew Lunn
[not found] ` <20150820163851.GG27457-g2DYL2Zd6BY@public.gmane.org>
2015-08-20 21:52 ` Maxime Ripard
2015-08-17 9:48 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D1DB24.8090602@linaro.org \
--to=srinivas.kandagatla-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).