From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
linux-sound@vger.kernel.org
Subject: [PATCH v2 1/4] ALSA: ppc: Remove i2c client removal hack
Date: Thu, 22 Aug 2024 21:47:18 +0200 [thread overview]
Message-ID: <55cab333-c9ca-4edd-a002-1e2b650a9f5a@gmail.com> (raw)
In-Reply-To: <3982b2a6-975e-40d2-bf02-2155e5c36c14@gmail.com>
The i2c_driver.clients list is internal to I2C core and is going
to be removed. No driver should access it. Unregister the
i2c client explicitly before deleting the i2c driver.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
sound/ppc/keywest.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c
index 3d3513d9d..4ce81ac7f 100644
--- a/sound/ppc/keywest.c
+++ b/sound/ppc/keywest.c
@@ -61,12 +61,6 @@ static int keywest_attach_adapter(struct i2c_adapter *adapter)
return -ENODEV;
}
- /*
- * Let i2c-core delete that device on driver removal.
- * This is safe because i2c-core holds the core_lock mutex for us.
- */
- list_add_tail(&keywest_ctx->client->detected,
- &to_i2c_driver(keywest_ctx->client->dev.driver)->clients);
return 0;
}
@@ -99,6 +93,7 @@ static struct i2c_driver keywest_driver = {
void snd_pmac_keywest_cleanup(struct pmac_keywest *i2c)
{
if (keywest_ctx && keywest_ctx == i2c) {
+ i2c_unregister_device(keywest_ctx->client);
i2c_del_driver(&keywest_driver);
keywest_ctx = NULL;
}
--
2.46.0
next prev parent reply other threads:[~2024-08-22 19:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 19:45 [PATCH v2 0/4] i2c: Replace lists of special clients with flagging of such clients Heiner Kallweit
2024-08-22 19:47 ` Heiner Kallweit [this message]
2024-08-23 7:49 ` [PATCH v2 1/4] ALSA: ppc: Remove i2c client removal hack Takashi Iwai
2024-08-22 19:48 ` [PATCH v2 2/4] i2c: Replace list-based mechanism for handling auto-detected clients Heiner Kallweit
2024-10-08 8:50 ` Wolfram Sang
2024-10-08 9:20 ` Wolfram Sang
2024-11-01 7:36 ` Wolfram Sang
2024-11-01 20:45 ` Heiner Kallweit
2024-11-01 20:57 ` Wolfram Sang
2024-11-01 21:16 ` Heiner Kallweit
2024-08-22 19:48 ` [PATCH v2 3/4] i2c: Replace list-based mechanism for handling userspace-created clients Heiner Kallweit
2024-10-08 9:00 ` Wolfram Sang
2024-08-22 19:49 ` [PATCH v2 4/4] i2c: core: Remove obsolete members of i2c_adapter and i2c_client Heiner Kallweit
2024-10-08 9:00 ` Wolfram Sang
2024-10-08 10:59 ` Heiner Kallweit
2024-09-01 9:30 ` [PATCH v2 0/4] i2c: Replace lists of special clients with flagging of such clients Wolfram Sang
2024-09-01 20:08 ` Heiner Kallweit
2024-09-30 10:10 ` Heiner Kallweit
2024-09-30 10:59 ` Wolfram Sang
2024-10-08 8:43 ` Wolfram Sang
2024-10-08 11:31 ` Heiner Kallweit
2024-10-29 6:44 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55cab333-c9ca-4edd-a002-1e2b650a9f5a@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).