[PATCH v2] i2c: enable i2c device to suspend/resume asynchronously

[PATCH v2] i2c: enable i2c device to suspend/resume asynchronously

[Fu, Zhonghui]

Now, PM core supports asynchronous suspend/resume mode for devices
during system suspend/resume, and the power state transition of one
device may be completed in separate kernel thread. PM core ensures
all power state transition timing dependency between devices. This
patch enables i2c device to suspend/resume asynchronously. This will
take advantage of multicore and improve system suspend/resume speed.

Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
---
Changes in v2:
- Amend commit message.

 drivers/i2c/i2c-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 5f89f1e..74e322b 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1036,6 +1036,7 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
 	client->dev.of_node = info->of_node;
 	client->dev.fwnode = info->fwnode;
 
+	device_enable_async_suspend(&client->dev);
 	i2c_dev_set_name(adap, client);
 	status = device_register(&client->dev);
 	if (status)
-- 1.7.1

Re: [PATCH v2] i2c: enable i2c device to suspend/resume asynchronously

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

On Thu, Sep 24, 2015 at 02:26:23PM +0800, Fu, Zhonghui wrote:
> Now, PM core supports asynchronous suspend/resume mode for devices
> during system suspend/resume, and the power state transition of one
> device may be completed in separate kernel thread. PM core ensures
> all power state transition timing dependency between devices. This
> patch enables i2c device to suspend/resume asynchronously. This will
> take advantage of multicore and improve system suspend/resume speed.
> 
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>

Does it always work when say a PMIC or clock controller is connected to
the I2C bus?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2] i2c: enable i2c device to suspend/resume asynchronously

[Fu, Zhonghui]

Hi,

Any comments are welcome.


Thanks,
Zhonghui



On 9/24/2015 2:26 PM, Fu, Zhonghui wrote:
> Now, PM core supports asynchronous suspend/resume mode for devices
> during system suspend/resume, and the power state transition of one
> device may be completed in separate kernel thread. PM core ensures
> all power state transition timing dependency between devices. This
> patch enables i2c device to suspend/resume asynchronously. This will
> take advantage of multicore and improve system suspend/resume speed.
>
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---
> Changes in v2:
> - Amend commit message.
>
>  drivers/i2c/i2c-core.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index 5f89f1e..74e322b 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1036,6 +1036,7 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
>  	client->dev.of_node = info->of_node;
>  	client->dev.fwnode = info->fwnode;
>  
> +	device_enable_async_suspend(&client->dev);
>  	i2c_dev_set_name(adap, client);
>  	status = device_register(&client->dev);
>  	if (status)
> -- 1.7.1
>

Re: [PATCH v2] i2c: enable i2c device to suspend/resume asynchronously

[Fu, Zhonghui]

On 10/20/2015 11:02 PM, Wolfram Sang wrote:
> On Thu, Sep 24, 2015 at 02:26:23PM +0800, Fu, Zhonghui wrote:
>> Now, PM core supports asynchronous suspend/resume mode for devices
>> during system suspend/resume, and the power state transition of one
>> device may be completed in separate kernel thread. PM core ensures
>> all power state transition timing dependency between devices. This
>> patch enables i2c device to suspend/resume asynchronously. This will
>> take advantage of multicore and improve system suspend/resume speed.
>>
>> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> Does it always work when say a PMIC or clock controller is connected to
> the I2C bus?
Sorry for missing this mail.

Yes, it does not care about what device. The sole difference of asynchronous suspend/resume mode is that the suspend/resume operation of one device is carried out in a separate kernel thread, and PM core ensures all related dependency.


Thanks,
Zhonghui


>