From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/6] i2c: designware: Remove interrupt clearing from i2c_dw_pci_probe()
Date: Mon, 12 Oct 2015 14:14:18 +0300 [thread overview]
Message-ID: <561B960A.7060400@linux.intel.com> (raw)
In-Reply-To: <20151010075337.GE1619@katana>
On 10/10/2015 10:53 AM, Wolfram Sang wrote:
> On Mon, Aug 31, 2015 at 05:31:28PM +0300, Jarkko Nikula wrote:
>> There is no need to clear interrupts in i2c_dw_pci_probe() since only place
>> where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts
>> are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always
>> clear interrupts before enabling them").
>
> Still, their status might be unclear when we init because firmware might
> have used it before. It should be easy to reintroduce this in patch 6,
> or?
>
Yes and then it would be also uniform across different enumeration
methods if we ever need to add it. Now this clearing was done only for
PCI devices. Although I don't think there is any need to add clearing to
probe path as clearing happens beginning of transmit before enabling the
interrupts.
--
Jarkko
next prev parent reply other threads:[~2015-10-12 11:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 14:31 [PATCH 0/6] i2c: designware: Code duplication removal and cleanups Jarkko Nikula
[not found] ` <1441031493-18938-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-08-31 14:31 ` [PATCH 1/6] i2c: designware: Remove interrupt clearing from i2c_dw_pci_probe() Jarkko Nikula
2015-10-10 7:53 ` Wolfram Sang
2015-10-12 11:14 ` Jarkko Nikula [this message]
2015-10-15 12:01 ` Wolfram Sang
2015-08-31 14:31 ` [PATCH 2/6] i2c: designware: Disable interrupts before requesting PCI device interrupt Jarkko Nikula
2015-08-31 14:31 ` [PATCH 3/6] i2c: designware: Remove unused functions Jarkko Nikula
2015-08-31 14:31 ` [PATCH 4/6] i2c: designware: Make dw_readl() and dw_writel() static Jarkko Nikula
2015-08-31 14:31 ` [PATCH 5/6] i2c: designware: Rename platform driver probe and PM functions Jarkko Nikula
2015-08-31 14:31 ` [PATCH 6/6] i2c: designware: Move common probe code into i2c_dw_probe() Jarkko Nikula
2015-10-10 7:57 ` Wolfram Sang
2015-10-12 11:38 ` Jarkko Nikula
2015-10-12 13:55 ` [PATCH v2 " Jarkko Nikula
2015-10-20 16:32 ` Wolfram Sang
2015-10-21 14:10 ` Jarkko Nikula
2015-10-15 12:18 ` [PATCH 0/6] i2c: designware: Code duplication removal and cleanups Wolfram Sang
2015-10-15 13:01 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561B960A.7060400@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).