From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-i2c@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] i2c: i801: Add support for Intel Broxton
Date: Mon, 26 Oct 2015 10:16:11 +0200 [thread overview]
Message-ID: <562DE14B.1080304@linux.intel.com> (raw)
In-Reply-To: <20151025115005.62c834f0@endymion.delvare>
Hi
On 10/25/2015 12:50 PM, Jean Delvare wrote:
>> @@ -204,6 +205,7 @@
>> #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS 0xa123
>> #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS 0x9d23
>> #define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df
>> +#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4
>
> Can you please get this added to pci.ids?
>
> http://pci-ids.ucw.cz/read/PC/8086
>
We seems to miss quite many other recent IDs too. I'll take this forward.
>> struct i801_mux_config {
>> char *gpio_chip;
>> @@ -866,6 +868,7 @@ static const struct pci_device_id i801_ids[] = {
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
>> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BROXTON_SMBUS) },
>> { 0, }
>> };
>>
>
> Does this one not have FEATURE_TCO as DNV does? If it does, you'll need
> to add a line for it in the switch block in i801_probe().
>
No, it's specific to sunrisepoint and dnv only at the moment.
> Please also update Documentation/i2c/busses/i2c-i801 and
> drivers/i2c/busses/Kconfig.
>
Ok, will do.
--
Jarkko
prev parent reply other threads:[~2015-10-26 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 14:16 [PATCH] i2c: i801: Add support for Intel Broxton Jarkko Nikula
2015-10-23 20:13 ` Wolfram Sang
2015-10-25 10:50 ` Jean Delvare
2015-10-26 8:16 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562DE14B.1080304@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).