From: fetzerch <fetzer.ch@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: Christian Fetzer <fetzer.ch@gmail.com>
Subject: Re: [PATCH] i2c: piix4: remove unneeded assignments
Date: Tue, 1 Dec 2015 21:31:52 +0100 [thread overview]
Message-ID: <565E03B8.6030807@googlemail.com> (raw)
In-Reply-To: <1448890989-32733-1-git-send-email-wsa@the-dreams.de>
Hi Wolfram,
On 30.11.2015 14:43, Wolfram Sang wrote:
> smatch rightfully says:
> drivers/i2c/busses/i2c-piix4.c:504 piix4_access warn: unused return: i = inb_p()
> drivers/i2c/busses/i2c-piix4.c:537 piix4_access warn: unused return: i = inb_p()
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> Christian, can you please check on HW? I could only compile-test.
Your patch works fine on my machine!
Thanks for merging my patchset btw.
Christian
>
> drivers/i2c/busses/i2c-piix4.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index af4e606f8886bd..e045985950737c 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> @@ -501,7 +501,7 @@ static s32 piix4_access(struct i2c_adapter * adap, u16 addr,
> if (len == 0 || len > I2C_SMBUS_BLOCK_MAX)
> return -EINVAL;
> outb_p(len, SMBHSTDAT0);
> - i = inb_p(SMBHSTCNT); /* Reset SMBBLKDAT */
> + inb_p(SMBHSTCNT); /* Reset SMBBLKDAT */
> for (i = 1; i <= len; i++)
> outb_p(data->block[i], SMBBLKDAT);
> }
> @@ -534,7 +534,7 @@ static s32 piix4_access(struct i2c_adapter * adap, u16 addr,
> data->block[0] = inb_p(SMBHSTDAT0);
> if (data->block[0] == 0 || data->block[0] > I2C_SMBUS_BLOCK_MAX)
> return -EPROTO;
> - i = inb_p(SMBHSTCNT); /* Reset SMBBLKDAT */
> + inb_p(SMBHSTCNT); /* Reset SMBBLKDAT */
> for (i = 1; i <= data->block[0]; i++)
> data->block[i] = inb_p(SMBBLKDAT);
> break;
>
next prev parent reply other threads:[~2015-12-01 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 13:43 [PATCH] i2c: piix4: remove unneeded assignments Wolfram Sang
2015-12-01 20:31 ` fetzerch [this message]
2015-12-03 20:37 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565E03B8.6030807@googlemail.com \
--to=fetzer.ch@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).