* [PATCH v2] arm64: dts: add all hi6220 i2c nodes
@ 2015-11-26 7:57 Xinwei Kong
2015-12-02 2:05 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Xinwei Kong @ 2015-11-26 7:57 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, galak, catalin.marinas,
will.deacon, tyler.baker, arnd, bintian.wang, devicetree,
linux-arm-kernel, linux-kernel, linux-i2c, shawnguo
Cc: puck.chen, liguozhu, w.f, kong.kongxinwei
This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
use this I2C IP of Synopsys Designware for HiKey board.
Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 82d2488..85d4a8b 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -208,5 +208,42 @@
clock-names = "uartclk", "apb_pclk";
status = "disabled";
};
+
+ i2c0: i2c@f7100000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xf7100000 0x0 0x1000>;
+ interrupts = <0 44 4>;
+ clocks = <&sys_ctrl HI6220_I2C0_CLK>;
+ clock-names = "clk_i2c0";
+ i2c-sda-hold-time-ns = <300>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
+ status = "disabled";
+ };
+
+ i2c1: i2c@f7101000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xf7101000 0x0 0x1000>;
+ interrupts = <0 45 4>;
+ clocks = <&sys_ctrl HI6220_I2C1_CLK>;
+ clock-names = "clk_i2c1";
+ i2c-sda-hold-time-ns = <300>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
+ status = "disabled";
+ };
+
+ i2c2: i2c@f7102000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xf7102000 0x0 0x1000>;
+ interrupts = <0 46 4>;
+ clocks = <&sys_ctrl HI6220_I2C2_CLK>;
+ clock-names = "clk_i2c2";
+ i2c-sda-hold-time-ns = <300>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
+ status = "disabled";
+ };
+
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: add all hi6220 i2c nodes
2015-11-26 7:57 [PATCH v2] arm64: dts: add all hi6220 i2c nodes Xinwei Kong
@ 2015-12-02 2:05 ` Shawn Guo
2015-12-02 2:40 ` Xinwei Kong
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2015-12-02 2:05 UTC (permalink / raw)
To: Xinwei Kong
Cc: robh+dt, pawel.moll, mark.rutland, galak, catalin.marinas,
will.deacon, tyler.baker, arnd, bintian.wang, devicetree,
linux-arm-kernel, linux-kernel, linux-i2c, puck.chen, liguozhu,
w.f
On Thu, Nov 26, 2015 at 03:57:03PM +0800, Xinwei Kong wrote:
> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
> use this I2C IP of Synopsys Designware for HiKey board.
>
> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 82d2488..85d4a8b 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -208,5 +208,42 @@
> clock-names = "uartclk", "apb_pclk";
> status = "disabled";
> };
> +
> + i2c0: i2c@f7100000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xf7100000 0x0 0x1000>;
> + interrupts = <0 44 4>;
> + clocks = <&sys_ctrl HI6220_I2C0_CLK>;
> + clock-names = "clk_i2c0";
Neither bindings doc i2c-designware.txt defines this property, nor
kernel i2c-designware driver uses this property. So I think this
clock-names property can just be dropped.
Otherwise, the patch looks good to me.
Shawn
> + i2c-sda-hold-time-ns = <300>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c@f7101000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xf7101000 0x0 0x1000>;
> + interrupts = <0 45 4>;
> + clocks = <&sys_ctrl HI6220_I2C1_CLK>;
> + clock-names = "clk_i2c1";
> + i2c-sda-hold-time-ns = <300>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@f7102000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xf7102000 0x0 0x1000>;
> + interrupts = <0 46 4>;
> + clocks = <&sys_ctrl HI6220_I2C2_CLK>;
> + clock-names = "clk_i2c2";
> + i2c-sda-hold-time-ns = <300>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
> + status = "disabled";
> + };
> +
> };
> };
> --
> 1.9.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: add all hi6220 i2c nodes
2015-12-02 2:05 ` Shawn Guo
@ 2015-12-02 2:40 ` Xinwei Kong
0 siblings, 0 replies; 3+ messages in thread
From: Xinwei Kong @ 2015-12-02 2:40 UTC (permalink / raw)
To: Shawn Guo
Cc: robh+dt, pawel.moll, mark.rutland, galak, catalin.marinas,
will.deacon, tyler.baker, arnd, bintian.wang, devicetree,
linux-arm-kernel, linux-kernel, linux-i2c, puck.chen, liguozhu,
w.f
hi Shawn
On 2015/12/2 10:05, Shawn Guo wrote:
> On Thu, Nov 26, 2015 at 03:57:03PM +0800, Xinwei Kong wrote:
>> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
>> use this I2C IP of Synopsys Designware for HiKey board.
>>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 82d2488..85d4a8b 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -208,5 +208,42 @@
>> clock-names = "uartclk", "apb_pclk";
>> status = "disabled";
>> };
>> +
>> + i2c0: i2c@f7100000 {
>> + compatible = "snps,designware-i2c";
>> + reg = <0x0 0xf7100000 0x0 0x1000>;
>> + interrupts = <0 44 4>;
>> + clocks = <&sys_ctrl HI6220_I2C0_CLK>;
>> + clock-names = "clk_i2c0";
>
> Neither bindings doc i2c-designware.txt defines this property, nor
> kernel i2c-designware driver uses this property. So I think this
> clock-names property can just be dropped.
>
This property should been delete it. I will debug it in HiKey board then
send v3 patch.
Thank you
xinwei
> Otherwise, the patch looks good to me.
>
> Shawn
>
>> + i2c-sda-hold-time-ns = <300>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@f7101000 {
>> + compatible = "snps,designware-i2c";
>> + reg = <0x0 0xf7101000 0x0 0x1000>;
>> + interrupts = <0 45 4>;
>> + clocks = <&sys_ctrl HI6220_I2C1_CLK>;
>> + clock-names = "clk_i2c1";
>> + i2c-sda-hold-time-ns = <300>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@f7102000 {
>> + compatible = "snps,designware-i2c";
>> + reg = <0x0 0xf7102000 0x0 0x1000>;
>> + interrupts = <0 46 4>;
>> + clocks = <&sys_ctrl HI6220_I2C2_CLK>;
>> + clock-names = "clk_i2c2";
>> + i2c-sda-hold-time-ns = <300>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>> --
>> 1.9.1
>>
>>
>>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-02 2:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 7:57 [PATCH v2] arm64: dts: add all hi6220 i2c nodes Xinwei Kong
2015-12-02 2:05 ` Shawn Guo
2015-12-02 2:40 ` Xinwei Kong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).