From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Loc Ho <lho@apm.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
wsa@the-dreams.de, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com, Ken Xue <Ken.Xue@amd.com>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided
Date: Wed, 16 Dec 2015 21:01:53 -0600 [thread overview]
Message-ID: <567225A1.7020001@amd.com> (raw)
In-Reply-To: <CAPw-ZTkMm1c6tLkEMiDrE=TENeUe3bm+U+CFHw231ngzWMqPuQ@mail.gmail.com>
On 12/16/2015 8:56 PM, Loc Ho wrote:
> Hi,
>
>> The current driver uses input clock source frequency to calculate
>> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not
>> currently have a good way to provide the frequency information.
>> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used
>> to directly provide these values. So, the clock information should
>> no longer be required during probing.
>>
>> However, since clk can be invalid, additional checks must be done where
>> we are making use of it.
>>
>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>> ---
>>
>> Note: This has been tested on AMD Seattle RevB for both DT and ACPI.
>
> Tested on X-Gene hardware also.
>
> -Loc
>
Thanks for quick response.
Suravee
next prev parent reply other threads:[~2015-12-17 3:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 2:23 [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided Suravee Suthikulpanit
2015-12-17 2:56 ` Loc Ho
2015-12-17 3:01 ` Suravee Suthikulanit [this message]
2015-12-18 10:13 ` Mika Westerberg
2015-12-22 20:51 ` Suravee Suthikulanit
2015-12-23 8:44 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567225A1.7020001@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=Ken.Xue@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).