From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulanit Subject: Re: [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided Date: Wed, 16 Dec 2015 21:01:53 -0600 Message-ID: <567225A1.7020001@amd.com> References: <1450319025-19120-1-git-send-email-Suravee.Suthikulpanit@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org To: Loc Ho Cc: Mika Westerberg , wsa@the-dreams.de, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, Ken Xue , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, Linux Kernel Mailing List List-Id: linux-i2c@vger.kernel.org On 12/16/2015 8:56 PM, Loc Ho wrote: > Hi, > >> The current driver uses input clock source frequency to calculate >> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not >> currently have a good way to provide the frequency information. >> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used >> to directly provide these values. So, the clock information should >> no longer be required during probing. >> >> However, since clk can be invalid, additional checks must be done where >> we are making use of it. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> >> Note: This has been tested on AMD Seattle RevB for both DT and ACPI. > > Tested on X-Gene hardware also. > > -Loc > Thanks for quick response. Suravee