* [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously
@ 2015-12-24 14:30 Fu, Zhonghui
2016-01-05 8:53 ` Jarkko Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Fu, Zhonghui @ 2015-12-24 14:30 UTC (permalink / raw)
To: Andy Shevchenko, jarkko.nikula, Mika Westerberg, Wolfram Sang
Cc: linux-i2c, linux-kernel@vger.kernel.org, srinivas.kowtal
Now, PM core supports asynchronous suspend/resume mode for devices
during system suspend/resume, and the power state transition of one
device may be completed in separate kernel thread. PM core ensures
all power state transition dependency between devices. This patch
enables designware i2c controllers to suspend/resume asynchronously.
This will take advantage of multicore and improve system suspend/resume
speed. After enabling all i2c devices, i2c adapters and i2c controllers
on ASUS T100TA tablet, the system suspend-to-idle time is reduced to
about 510ms from 750ms, and the system resume time is reduced to about
790ms from 900ms.
Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 6b00061..395130b 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -230,6 +230,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
}
adap = &dev->adapter;
+ device_enable_async_suspend(&pdev->dev);
adap->owner = THIS_MODULE;
adap->class = I2C_CLASS_DEPRECATED;
ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
-- 1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously
2015-12-24 14:30 [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously Fu, Zhonghui
@ 2016-01-05 8:53 ` Jarkko Nikula
2016-01-05 12:14 ` Andy Shevchenko
2016-01-15 6:42 ` Fu, Zhonghui
0 siblings, 2 replies; 8+ messages in thread
From: Jarkko Nikula @ 2016-01-05 8:53 UTC (permalink / raw)
To: Fu, Zhonghui, Andy Shevchenko, Mika Westerberg, Wolfram Sang
Cc: linux-i2c, linux-kernel@vger.kernel.org, srinivas.kowtal
Hi
On 12/24/2015 04:30 PM, Fu, Zhonghui wrote:
> Now, PM core supports asynchronous suspend/resume mode for devices
> during system suspend/resume, and the power state transition of one
> device may be completed in separate kernel thread. PM core ensures
> all power state transition dependency between devices. This patch
> enables designware i2c controllers to suspend/resume asynchronously.
> This will take advantage of multicore and improve system suspend/resume
> speed. After enabling all i2c devices, i2c adapters and i2c controllers
> on ASUS T100TA tablet, the system suspend-to-idle time is reduced to
> about 510ms from 750ms, and the system resume time is reduced to about
> 790ms from 900ms.
>
Nice reduction :-)
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 6b00061..395130b 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -230,6 +230,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
> }
>
> adap = &dev->adapter;
> + device_enable_async_suspend(&pdev->dev);
> adap->owner = THIS_MODULE;
> adap->class = I2C_CLASS_DEPRECATED;
> ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
Does device_enable_async_suspend() need to be called before enabling
runtime PM? I suppose not since there appears to have also related sysfs
node for toggling it runtime.
I'm thinking if you could move the device_enable_async_suspend() call
into drivers/i2c/busses/i2c-designware-core.c: i2c_dw_probe() and then
also PCI enumerated adapter could take advantage of it.
--
Jarkko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously
2016-01-05 8:53 ` Jarkko Nikula
@ 2016-01-05 12:14 ` Andy Shevchenko
2016-01-15 7:01 ` Fu, Zhonghui
2016-01-15 6:42 ` Fu, Zhonghui
1 sibling, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2016-01-05 12:14 UTC (permalink / raw)
To: Jarkko Nikula, Fu, Zhonghui, Mika Westerberg, Wolfram Sang
Cc: linux-i2c, linux-kernel@vger.kernel.org, srinivas.kowtal
On Tue, 2016-01-05 at 10:53 +0200, Jarkko Nikula wrote:
> Hi
>
> On 12/24/2015 04:30 PM, Fu, Zhonghui wrote:
> > Now, PM core supports asynchronous suspend/resume mode for devices
> > during system suspend/resume, and the power state transition of one
> > device may be completed in separate kernel thread. PM core ensures
> > all power state transition dependency between devices. This patch
> > enables designware i2c controllers to suspend/resume
> > asynchronously.
> > This will take advantage of multicore and improve system
> > suspend/resume
> > speed. After enabling all i2c devices, i2c adapters and i2c
> > controllers
> > on ASUS T100TA tablet, the system suspend-to-idle time is reduced
> > to
> > about 510ms from 750ms, and the system resume time is reduced to
> > about
> > 790ms from 900ms.
> >
> Nice reduction :-)
>
> > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
> > b/drivers/i2c/busses/i2c-designware-platdrv.c
> > index 6b00061..395130b 100644
> > --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> > @@ -230,6 +230,7 @@ static int dw_i2c_plat_probe(struct
> > platform_device *pdev)
> > }
> >
> > adap = &dev->adapter;
> > + device_enable_async_suspend(&pdev->dev);
> > adap->owner = THIS_MODULE;
> > adap->class = I2C_CLASS_DEPRECATED;
> > ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev-
> > >dev));
>
> Does device_enable_async_suspend() need to be called before enabling
> runtime PM? I suppose not since there appears to have also related
> sysfs
> node for toggling it runtime.
>
> I'm thinking if you could move the device_enable_async_suspend() call
> into drivers/i2c/busses/i2c-designware-core.c: i2c_dw_probe() and
> then
> also PCI enumerated adapter could take advantage of it.
I concern about Intel BayTrail-T / Braswell / CherryTrail cases, since
we have non-trivial PM for LPSS there. Zhonghui, have you a chance to
stress test this on platforms based on mentioned SoCs?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously
2016-01-05 12:14 ` Andy Shevchenko
@ 2016-01-15 7:01 ` Fu, Zhonghui
0 siblings, 0 replies; 8+ messages in thread
From: Fu, Zhonghui @ 2016-01-15 7:01 UTC (permalink / raw)
To: Andy Shevchenko, Jarkko Nikula, Mika Westerberg, Wolfram Sang
Cc: linux-i2c, linux-kernel@vger.kernel.org, srinivas.kowtal
On 1/5/2016 8:14 PM, Andy Shevchenko wrote:
> On Tue, 2016-01-05 at 10:53 +0200, Jarkko Nikula wrote:
>> Hi
>>
>> On 12/24/2015 04:30 PM, Fu, Zhonghui wrote:
>>> Now, PM core supports asynchronous suspend/resume mode for devices
>>> during system suspend/resume, and the power state transition of one
>>> device may be completed in separate kernel thread. PM core ensures
>>> all power state transition dependency between devices. This patch
>>> enables designware i2c controllers to suspend/resume
>>> asynchronously.
>>> This will take advantage of multicore and improve system
>>> suspend/resume
>>> speed. After enabling all i2c devices, i2c adapters and i2c
>>> controllers
>>> on ASUS T100TA tablet, the system suspend-to-idle time is reduced
>>> to
>>> about 510ms from 750ms, and the system resume time is reduced to
>>> about
>>> 790ms from 900ms.
>>>
>> Nice reduction :-)
>>
>>> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
>>> b/drivers/i2c/busses/i2c-designware-platdrv.c
>>> index 6b00061..395130b 100644
>>> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
>>> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
>>> @@ -230,6 +230,7 @@ static int dw_i2c_plat_probe(struct
>>> platform_device *pdev)
>>> }
>>>
>>> adap = &dev->adapter;
>>> + device_enable_async_suspend(&pdev->dev);
>>> adap->owner = THIS_MODULE;
>>> adap->class = I2C_CLASS_DEPRECATED;
>>> ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev-
>>>> dev));
>> Does device_enable_async_suspend() need to be called before enabling
>> runtime PM? I suppose not since there appears to have also related
>> sysfs
>> node for toggling it runtime.
>>
>> I'm thinking if you could move the device_enable_async_suspend() call
>> into drivers/i2c/busses/i2c-designware-core.c: i2c_dw_probe() and
>> then
>> also PCI enumerated adapter could take advantage of it.
> I concern about Intel BayTrail-T / Braswell / CherryTrail cases, since
> we have non-trivial PM for LPSS there. Zhonghui, have you a chance to
> stress test this on platforms based on mentioned SoCs?
Because of long leave, so sorry for late reply.
I understand what you said, if enable all LPSS devices suspend/resume asynchronously, the system can't resume sometimes on ASUS T100TA(BayTrail-T SoC). But, I have verified that the system can resume normally every time if enable only i2c controller async mode and let other LPSS devices in sync mode on ASUS T100TA. I have no Braswell and cherryTrail platforms, so no verification test on them.
I have submitted a new version of this patch to move the device_enable_async_suspend() call into i2c_dw_proble() function - "[PATCH v2] i2c/designware: enable i2c controller to suspend/resume asynchronously".
Thanks,
Zhonghui
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously
2016-01-05 8:53 ` Jarkko Nikula
2016-01-05 12:14 ` Andy Shevchenko
@ 2016-01-15 6:42 ` Fu, Zhonghui
1 sibling, 0 replies; 8+ messages in thread
From: Fu, Zhonghui @ 2016-01-15 6:42 UTC (permalink / raw)
To: Jarkko Nikula, Andy Shevchenko, Mika Westerberg, Wolfram Sang
Cc: linux-i2c, linux-kernel@vger.kernel.org, srinivas.kowtal
On 1/5/2016 4:53 PM, Jarkko Nikula wrote:
> Hi
>
> On 12/24/2015 04:30 PM, Fu, Zhonghui wrote:
>> Now, PM core supports asynchronous suspend/resume mode for devices
>> during system suspend/resume, and the power state transition of one
>> device may be completed in separate kernel thread. PM core ensures
>> all power state transition dependency between devices. This patch
>> enables designware i2c controllers to suspend/resume asynchronously.
>> This will take advantage of multicore and improve system suspend/resume
>> speed. After enabling all i2c devices, i2c adapters and i2c controllers
>> on ASUS T100TA tablet, the system suspend-to-idle time is reduced to
>> about 510ms from 750ms, and the system resume time is reduced to about
>> 790ms from 900ms.
>>
> Nice reduction :-)
>
>> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
>> index 6b00061..395130b 100644
>> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
>> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
>> @@ -230,6 +230,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
>> }
>>
>> adap = &dev->adapter;
>> + device_enable_async_suspend(&pdev->dev);
>> adap->owner = THIS_MODULE;
>> adap->class = I2C_CLASS_DEPRECATED;
>> ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
>
> Does device_enable_async_suspend() need to be called before enabling runtime PM? I suppose not since there appears to have also related sysfs node for toggling it runtime.
>
> I'm thinking if you could move the device_enable_async_suspend() call into drivers/i2c/busses/i2c-designware-core.c: i2c_dw_probe() and then also PCI enumerated adapter could take advantage of it.
Because of long leave, so sorry for late reply.
Your proposal is right. I have submitted a new patch according to your comments - "[PATCH v2] i2c/designware: enable i2c controller to suspend/resume asynchronously".
Thanks,
Zhonghui
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously
@ 2015-08-17 16:36 Fu, Zhonghui
[not found] ` <55D20D79.3090308-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Fu, Zhonghui @ 2015-08-17 16:36 UTC (permalink / raw)
To: wsa-z923LK4zBo2bacvFa/9K2g
Cc: Mika Westerberg, christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ,
atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx,
jszhang-eYqpPyKDWXRBDgjK7y7TUQ,
raymond.tan-ral2JQCrhuEAvxtiuMwx3w,
Romain.Baeriswyl-ux6zf3SgZrrQT0dZR+AlfA,
carlpeng008-Re5JQEeQqe8AvxtiuMwx3w,
david.e.box-VuQAYsv1563Yd54FQh9/CA,
Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/w,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Enable i2c controller to suspend/resume asynchronously. This can improve
system suspend/resume speed.
Signed-off-by: Zhonghui Fu <zhonghui.fu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 3dd2de3..fec0fce 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -245,6 +245,7 @@ static int dw_i2c_probe(struct platform_device *pdev)
adap = &dev->adapter;
i2c_set_adapdata(adap, dev);
+ device_enable_async_suspend(&pdev->dev);
adap->owner = THIS_MODULE;
adap->class = I2C_CLASS_DEPRECATED;
strlcpy(adap->name, "Synopsys DesignWare I2C adapter",
-- 1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-15 7:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-24 14:30 [PATCH] i2c/designware: enable i2c controller to suspend/resume asynchronously Fu, Zhonghui
2016-01-05 8:53 ` Jarkko Nikula
2016-01-05 12:14 ` Andy Shevchenko
2016-01-15 7:01 ` Fu, Zhonghui
2016-01-15 6:42 ` Fu, Zhonghui
-- strict thread matches above, loose matches on Subject: below --
2015-08-17 16:36 Fu, Zhonghui
[not found] ` <55D20D79.3090308-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-08-24 15:23 ` Fu, Zhonghui
2015-09-24 7:12 ` Fu, Zhonghui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).