[PATCH v1 1/1] i2c: designware-pci: use IRQF_COND_SUSPEND flag

[PATCH v1 1/1] i2c: designware-pci: use IRQF_COND_SUSPEND flag

[Andy Shevchenko]

This is effectively reapplies the commit b0898fdaffb2 (i2c: designware-pci: use
IRQF_COND_SUSPEND flag) after the commit d80d134182ba (i2c: designware: Move
common probe code into i2c_dw_probe()). Original message as follows.

The mentioned flag fixes a warning on Intel Edison board since one of the I2C
controller shares IRQ line with watchdog timer.

Fixes: d80d134182ba (i2c: designware: Move common probe code into i2c_dw_probe())
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-designware-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
index ba9732c..10fbd6d 100644
--- a/drivers/i2c/busses/i2c-designware-core.c
+++ b/drivers/i2c/busses/i2c-designware-core.c
@@ -874,7 +874,8 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
 	i2c_set_adapdata(adap, dev);
 
 	i2c_dw_disable_int(dev);
-	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, IRQF_SHARED,
+	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
+			     IRQF_SHARED | IRQF_COND_SUSPEND,
 			     dev_name(dev->dev), dev);
 	if (r) {
 		dev_err(dev->dev, "failure requesting irq %i: %d\n",
-- 
2.7.0.rc3

Re: [PATCH v1 1/1] i2c: designware-pci: use IRQF_COND_SUSPEND flag

[Jarkko Nikula]

On 01/15/2016 10:02 PM, Andy Shevchenko wrote:
> This is effectively reapplies the commit b0898fdaffb2 (i2c: designware-pci: use
> IRQF_COND_SUSPEND flag) after the commit d80d134182ba (i2c: designware: Move
> common probe code into i2c_dw_probe()). Original message as follows.
>
> The mentioned flag fixes a warning on Intel Edison board since one of the I2C
> controller shares IRQ line with watchdog timer.
>
> Fixes: d80d134182ba (i2c: designware: Move common probe code into i2c_dw_probe())
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/i2c/busses/i2c-designware-core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Re: [PATCH v1 1/1] i2c: designware-pci: use IRQF_COND_SUSPEND flag

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

On Fri, Jan 15, 2016 at 10:02:12PM +0200, Andy Shevchenko wrote:
> This is effectively reapplies the commit b0898fdaffb2 (i2c: designware-pci: use
> IRQF_COND_SUSPEND flag) after the commit d80d134182ba (i2c: designware: Move
> common probe code into i2c_dw_probe()). Original message as follows.
> 
> The mentioned flag fixes a warning on Intel Edison board since one of the I2C
> controller shares IRQ line with watchdog timer.
> 
> Fixes: d80d134182ba (i2c: designware: Move common probe code into i2c_dw_probe())
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Fixed this checkpatch error:

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d80d134182ba ("i2c: designware: Move common probe code into i2c_dw_probe()")'

and applied to for-current, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]