From: Dmitriy Baranov <dbaranov@dev.rtsoft.ru>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Maxim Syrchin <syrchin@dev.rtsoft.ru>
Cc: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: imx: add slave support
Date: Tue, 26 Jan 2016 17:13:43 +0300 [thread overview]
Message-ID: <56A77F17.6090903@dev.rtsoft.ru> (raw)
In-Reply-To: <56A776A9.1070508@mentor.com>
Vladimir,
Thanks for the comment.
We are both the authors of this patch.
> Could you please squash the changes (care about indentation in Kconfig also)
> and resend it as v2 (probably you may want to wait for review comments some
> more time)?
I suppose that after review, there will be many other things to fix in
this patch.
Thus, if you don`t mind, we wont send fixed version for now.
On 26.01.2016 16:37, Vladimir Zapolskiy wrote:
> On 26.01.2016 11:54, Dmitriy Baranov wrote:
>> Sorry, we should have added selecting this in our patch.
>> The following fixes it:
>>
>> Subject: [PATCH] Select I2C_SLAVE for i2c-imx driver because it uses the
>> generic slave interface.
>>
>> Signed-off-by: Dmitriy Baranov <dbaranov@dev.rtsoft.ru>
>> Signed-off-by: Maxim Syrchin <syrchin@dev.rtsoft.ru>
>> ---
>> drivers/i2c/busses/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 0299dfa..bc7cbfd 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -587,6 +587,7 @@ config I2C_IMG
>> config I2C_IMX
>> tristate "IMX I2C interface"
>> depends on ARCH_MXC || ARCH_LAYERSCAPE
>> + select I2C_SLAVE
>> help
>> Say Y here if you want to use the IIC bus controller on
>> the Freescale i.MX/MXC or Layerscape processors.
>>
> Could you please squash the changes (care about indentation in Kconfig also)
> and resend it as v2 (probably you may want to wait for review comments some
> more time)?
>
> Two more formal questions, why patch submitter's Signed-off-by: is not the
> last in the list and why Maxim has Signed-off-by tag here? Who is the author
> of the change?
>
> See Documentation/SubmittingPatches "Sign your work" for details.
>
> Best wishes,
> Vladimir
next prev parent reply other threads:[~2016-01-26 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 14:53 [PATCH] i2c: imx: add slave support Dmitriy Baranov
2016-01-25 18:09 ` kbuild test robot
2016-01-26 8:22 ` Dmitriy Baranov
2016-01-26 8:36 ` Wolfram Sang
2016-01-26 9:54 ` Dmitriy Baranov
2016-01-26 13:37 ` Vladimir Zapolskiy
2016-01-26 14:13 ` Dmitriy Baranov [this message]
2016-01-26 15:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A77F17.6090903@dev.rtsoft.ru \
--to=dbaranov@dev.rtsoft.ru \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syrchin@dev.rtsoft.ru \
--cc=vladimir_zapolskiy@mentor.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).