From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] i2c: designware-baytrail: Fix the Kconfig dependency fix Date: Thu, 4 Feb 2016 13:47:00 +0200 Message-ID: <56B33A34.7000400@linux.intel.com> References: <20160202143324.780986be@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:1370 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932994AbcBDLrD (ORCPT ); Thu, 4 Feb 2016 06:47:03 -0500 In-Reply-To: <20160202143324.780986be@endymion> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Jean Delvare , Linux I2C Cc: Randy Dunlap , "David E. Box" , "Signed-off-by: Wolfram Sang" On 02/02/2016 03:33 PM, Jean Delvare wrote: > Commit b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for > proper Kconfig dependencies") claims that the "Baytrail driver" isn't > tristate. But in fact there is no such thing as a "Baytrail driver", > i2c-designware-baytrail is not a stand-alone driver but an optional > addition to the i2c-designware-platform driver, and that driver *is* > tristate. So there is no reason why I2C_DESIGNWARE_BAYTRAIL couldn't > be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too. > I had a similar patch waiting for David's ack because I didn't know are there any problems when IOSF_MBI is module but I forgot to ping again. David: can you ack this in case IOSF_MBI=m is ok. > Signed-off-by: Jean Delvare > Fixes: b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies") > Cc: Randy Dunlap > Cc: David E. Box > Cc: Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-4.5-rc2.orig/drivers/i2c/busses/Kconfig 2016-02-02 13:36:02.621152859 +0100 > +++ linux-4.5-rc2/drivers/i2c/busses/Kconfig 2016-02-02 14:06:07.185912775 +0100 > @@ -490,7 +490,7 @@ config I2C_DESIGNWARE_PCI > > config I2C_DESIGNWARE_BAYTRAIL > bool "Intel Baytrail I2C semaphore support" > - depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI > + depends on I2C_DESIGNWARE_PLATFORM && (IOSF_MBI=y || IOSF_MBI=I2C_DESIGNWARE_PLATFORM) && ACPI One minor comment: could you split this into two depends on lines in order to avoid long lines? Reviewed-by: Jarkko Nikula