From: Michal Simek <michal.simek@xilinx.com>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-i2c@vger.kernel.org
Cc: soren.brinkmann@xilinx.com, michal.simek@xilinx.com,
wsa@the-dreams.de, Shubhrajyoti Datta <shubhraj@xilinx.com>
Subject: Re: [PATCH 1/2] i2c: cadence: Fix the Documentation
Date: Tue, 1 Mar 2016 08:33:09 +0100 [thread overview]
Message-ID: <56D545B5.9060304@xilinx.com> (raw)
In-Reply-To: <1456813959-20398-1-git-send-email-shubhraj@xilinx.com>
On 1.3.2016 07:32, Shubhrajyoti Datta wrote:
> The runtime adaptation patch missed the documentation update.
> This fixes the same.
> No functional change.
>
> Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
> ---
> drivers/i2c/busses/i2c-cadence.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index 6b08d16..a761520 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -815,7 +815,7 @@ static int cdns_i2c_clk_notifier_cb(struct notifier_block *nb, unsigned long
> }
>
> /**
> - * cdns_i2c_suspend - Suspend method for the driver
> + * cdns_i2c_runtime_suspend - Runtime suspend method for the driver
> * @_dev: Address of the platform_device structure
you should fix this parameter too.
> *
> * Put the driver into low power mode.
> @@ -833,7 +833,7 @@ static int __maybe_unused cdns_i2c_runtime_suspend(struct device *dev)
> }
>
> /**
> - * cdns_i2c_resume - Resume from suspend
> + * cdns_i2c_runtime_resume - Runtime resume
> * @_dev: Address of the platform_device structure
and here too.
> *
> * Resume operation after suspend.
>
There is also undocumented dev. Please fix it too.
drivers/i2c/busses/i2c-cadence.c:126: info: Scanning doc for struct cdns_i2c
drivers/i2c/busses/i2c-cadence.c:164: warning: No description found for
parameter 'dev'
Thanks,
Michal
next prev parent reply other threads:[~2016-03-01 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 6:32 [PATCH 1/2] i2c: cadence: Fix the Documentation Shubhrajyoti Datta
2016-03-01 6:32 ` [PATCH 2/2] i2c: cadence: Implement save restore Shubhrajyoti Datta
2016-03-01 7:34 ` Michal Simek
2016-03-01 9:25 ` Shubhrajyoti Datta
2016-03-01 7:33 ` Michal Simek [this message]
2016-03-01 9:23 ` [PATCH 1/2] i2c: cadence: Fix the Documentation Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D545B5.9060304@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-i2c@vger.kernel.org \
--cc=shubhraj@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox