Re: [Patch v1] i2c: imx7ulp: add i.MX7ULP i2c controller bus driver

[Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>]

Hello,

On 15.03.2016 11:51, Gao Pan wrote:
> Add i.MX7ULP i2c bus driver which can continue operating
> in stop modes provided an appropriate clock is available.
> 
> It is also designed for low CPU overhead with DMA offloading
> of FIFO register accesses.
> 
> Signed-off-by: Gao Pan <pandy.gao@nxp.com>
> ---

[snip]

> +
> +static int i2c_imx7ulp_start(struct imx7ulp_i2c_struct *i2c_imx7ulp)
> +{
> +	int ret;
> +	unsigned int temp;
> +
> +	dev_dbg(&i2c_imx7ulp->adapter.dev, "<%s>\n", __func__);
> +
> +	ret = clk_prepare_enable(i2c_imx7ulp->bus_clk);
> +	if (ret) {
> +		dev_err(&i2c_imx7ulp->adapter.dev,
> +			"can't enable I2C bus clock, ret=%d\n", ret);
> +		return ret;
> +	}
> +
> +	ret = clk_prepare_enable(i2c_imx7ulp->per_clk);
> +	if (ret) {
> +		dev_err(&i2c_imx7ulp->adapter.dev,
> +			"can't enable I2C peripheral clock, ret=%d\n", ret);
> +		return ret;

Leaked prepared/enabled i2c_imx7ulp->bus_clk clock on error path.

> +	}
> +

--
With best wishes,
Vladimir