From: Jon Hunter <jonathanh@nvidia.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: core: Add missing of_node_put()
Date: Fri, 15 Apr 2016 16:34:00 +0100 [thread overview]
Message-ID: <571109E8.70005@nvidia.com> (raw)
In-Reply-To: <5711019E.9020304@mentor.com>
On 15/04/16 15:58, Vladimir Zapolskiy wrote:
> On 15.04.2016 15:43, Jon Hunter wrote:
>> for_each_available_child_of_node performs an of_node_get on each
>> iteration, so of_node_put() must be called on each iteration once
>> we are finished with the node pointer.
>
> This is wrong, embedded of_get_next_available_child() correctly decrements
> ref counter of an examined node.
Oh yes, sorry, I see that now. Sorry for the noise and mis-interpretation here :-(
Jon
prev parent reply other threads:[~2016-04-15 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 12:43 [PATCH] i2c: core: Add missing of_node_put() Jon Hunter
2016-04-15 14:58 ` Vladimir Zapolskiy
2016-04-15 15:34 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571109E8.70005@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).