From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Date: Thu, 21 Apr 2016 09:18:10 +0200 Message-ID: <57187EB2.70707@samsung.com> References: <1461163076-5959-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:35853 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbcDUHSP (ORCPT ); Thu, 21 Apr 2016 03:18:15 -0400 In-reply-to: <1461163076-5959-1-git-send-email-javier@osg.samsung.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, Wolfram Sang , Kukjin Kim , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote: > The driver not always prints the error code in case of a failure but this > information can be very useful for debugging. So let's print if available. > > Signed-off-by: Javier Martinez Canillas > > --- > > Hello, > > This patch and 2/2 were only build tested because I don't have access to > a board using this IP block. I just noticed these issues when comparing > the i2c-s3c2410 driver with i2c-exynos5 where I did some fixes recently. > > I think the patches are simple enough that is safe to pick them but of > course testing will be highly appreciated. > > Best regards, > Javier > > Changes in v2: > - Don't print the errno code on probe since it's already printed by the > core. Suggested by Krzysztof Kozlowski. > > drivers/i2c/busses/i2c-s3c2410.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c) Tested-by: Krzysztof Kozlowski Best regards, Krzysztof