Re: [PATCH] i2c: at91: change log when dma configuration fails

Ludovic Desroches
2016-05-13T11:48:51Z

On Fri, May 13, 2016 at 11:53:09AM +0200, Mason wrote:
> On 13/05/2016 11:22, Ludovic Desroches wrote:
>
> > When the DMA configuration fails, there is a log reporting that we can't
> > use DMA and indicating the error number. When booting the kernel, it is
> > annoying to see this error number. Moreover, people can think something
> > is going wrong. It is not the case, it means that DMA can't be used but
> > it doesn't prevent to use i2c.
> >
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> > ---
> > drivers/i2c/busses/i2c-at91.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> > index 921d32b..f2a7457 100644
> > --- a/drivers/i2c/busses/i2c-at91.c
> > +++ b/drivers/i2c/busses/i2c-at91.c
> > @@ -1013,7 +1013,9 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
> >
> > error:
> > if (ret != -EPROBE_DEFER)
> > - dev_info(dev->dev, "can't use DMA, error %d\n", ret);
> > + dev_info(dev->dev,
> > + "can't request DMA channels, continue without DMA support\n",
> > + ret);
>
> Did you forget to remove 'ret' after removing the %d format spec?
>

Oh yes, thanks. v2 is coming !

Regards