From: Thomas Zimmermann <tdz@users.sourceforge.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: Raise SDA for each received bit, if necessary
Date: Fri, 13 May 2016 18:06:53 +0200 [thread overview]
Message-ID: <5735FB9D.2060300@users.sourceforge.net> (raw)
In-Reply-To: <20160513103355.GE1778@katana>
Hi
Am 13.05.2016 um 12:33 schrieb Wolfram Sang:
>
>> I was playing with the DRM framework and an old SiS graphics card. I
>> discovered this issue while trying to read the EDID from the monitor.
>
> So, there is no upstream user yet?
No.
>> I have a few other SiS cards/models here and they all expose this
>> behavior. So I guess it's intentional(==cheaper?), although the HW docs
>> don't seem mention it explicitly.
>
> OK. Well. As this flag is potentially dangerous, I would prefer to not
> apply the patch unless there is an upstream user of this. If there is
> one, I'd be okay with applying it with the flag renamed to something
> like "dangerous_push_pull_bus" or similar with additional comments
> saying there is some (broken) HW which needs it but nobody should get
> the idea to design a bus like this.
>
> Makes sense?
Sure, thanks!
Best regards
Thomas
> Regards,
>
> Wolfram
>
--
GnuPG: http://tdz.users.sourceforge.net/tdz.asc
Fingerprint: 16FF F599 82F8 E5AA 18C6 5220 D9DA D7D4 4EF1 DF08
prev parent reply other threads:[~2016-05-13 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 18:11 [PATCH] i2c: Raise SDA for each received bit, if necessary Thomas Zimmermann
2016-05-12 9:05 ` Wolfram Sang
2016-05-12 16:19 ` Thomas Zimmermann
2016-05-13 10:33 ` Wolfram Sang
2016-05-13 16:06 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5735FB9D.2060300@users.sourceforge.net \
--to=tdz@users.sourceforge.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).