From: Timur Tabi <timur@codeaurora.org>
To: Naveen Kaje <nkaje@codeaurora.org>,
Sricharan <sricharan@codeaurora.org>,
wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, rruigrok@codeaurora.org,
cov@codeaurora.org, austinwc@codeaurora.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] i2c: qup: support SMBus block read
Date: Thu, 19 May 2016 15:21:48 -0500 [thread overview]
Message-ID: <573E205C.9080701@codeaurora.org> (raw)
In-Reply-To: <757c18e2-562a-9f43-0fb6-ab3e7ac3af88@codeaurora.org>
Naveen Kaje wrote:
>>>
>>> + tags[len++] = QUP_TAG_V2_DATARD;
>>> + /* 0 implies 256 bytes */
>>> + if (data_len == QUP_READ_LIMIT)
>>> + tags[len++] = 0;
>>> + else
>>> + tags[len++] = data_len;
>>> + }
>> Even data_len will always be '1' right ?
> Yes, but here preferably we use a variable than a number without a context.
Actually, I would say the opposite. I would rather see a constant with
a comment explaining it, than a variable that we know will always
contain only one number.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.
next prev parent reply other threads:[~2016-05-19 20:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:45 [PATCH v2 1/2] i2c: qup: add ACPI support Naveen Kaje
2016-05-11 22:45 ` [PATCH v2 2/2] i2c: qup: support SMBus block read Naveen Kaje
2016-05-18 7:06 ` Sricharan
2016-05-19 20:14 ` Naveen Kaje
2016-05-19 20:21 ` Timur Tabi [this message]
2016-05-19 21:16 ` Naveen Kaje
2016-05-20 8:31 ` Sricharan
2016-05-23 17:45 ` Christ, Austin
2016-05-18 6:04 ` [PATCH v2 1/2] i2c: qup: add ACPI support Sricharan
2016-05-19 20:13 ` Naveen Kaje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573E205C.9080701@codeaurora.org \
--to=timur@codeaurora.org \
--cc=austinwc@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nkaje@codeaurora.org \
--cc=rruigrok@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).