From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] i2c: tegra: Correct error path in probe Date: Tue, 5 Jul 2016 14:21:23 +0100 Message-ID: <577BB453.7020903@nvidia.com> References: <1465936007-18599-1-git-send-email-jonathanh@nvidia.com> <5770F1D4.8000406@nvidia.com> <5770F2CB.2090109@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5770F2CB.2090109@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: Laxman Dewangan , Stephen Warren , Thierry Reding , Alexandre Courbot , Shardar Shariff Md , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-i2c@vger.kernel.org Wolfram, On 27/06/16 10:32, Laxman Dewangan wrote: > > On Monday 27 June 2016 02:58 PM, Jon Hunter wrote: >> Hi all, >> >> On 14/06/16 21:26, Jon Hunter wrote: >>> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device >>> *pdev) >>> ret = tegra_i2c_init(i2c_dev); >>> if (ret) { >>> dev_err(&pdev->dev, "Failed to initialize i2c controller"); >>> - goto unprepare_div_clk; >>> + goto disable_div_clk; >>> } >>> > > Yes, this looks correct. > > Acked-by: Laxman Dewangan Can you pick this one up? Cheers Jon -- nvpublic