linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kandziora <jjj@gmx.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: Introducing a kernel driver for the DS28E17 Onewire to I2C master bridge; Feature request: introduce I2C_FUNC_STOP
Date: Fri, 15 Jul 2016 13:13:16 +0200	[thread overview]
Message-ID: <5788C54C.20705@gmx.de> (raw)
In-Reply-To: <20160714131921.GE4149@tetsubishi>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 14.07.2016 um 15:19 schrieb Wolfram Sang:
> 
>> The datasheet says it can at least for a write to the pointer
>> byte followed by a read but it doesn't seem to work.
>> 
>> - From my tests, it doesn't work, or it least it doesn't work the
>> way the ds28e17 bus master does the repeated start.
> 
> It would be really good if that would work. Having a STOP betwen
> those messages is unsafe. It won't probably matter for your setup,
> but still...
> 
I checked it again and it turned out to be a bug in my driver code,
living there from my very first tries. The DS28E17 and DS7505 in
conjunction support the Restart Condition.

So, please discard my request for I2C_FUNC_STOP. It's not needed.


But I have another question, this time regarding I2C_FUNC_NOSTART. The
DS28E17 can do an I2C write transfer without Start Condition, to
continue a previous write without Stop Condition. My driver already
uses that internally to do continous writes of more than 255 bytes,
the buffer limit of the DS28E17.


BUT, the DS28E17 can only do this for writes. Not for reads. Does it
make sense to expose that feature and announce it as I2C_FUNC_NOSTART
then?

Kind regards

	Jan





-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAleIxUYACgkQzGZqmZvWQdnypwCgnrHFhOnGesAwn9P6qnrRA+UK
yZ0An02KMy1Z+vKB8VO8Pn0XKFXP4e0t
=Tqkg
-----END PGP SIGNATURE-----

  reply	other threads:[~2016-07-15 11:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 10:07 Introducing a kernel driver for the DS28E17 Onewire to I2C master bridge; Feature request: introduce I2C_FUNC_STOP Jan Kandziora
2016-07-14  9:58 ` Wolfram Sang
2016-07-14 12:53   ` Jan Kandziora
2016-07-14 13:19     ` Wolfram Sang
2016-07-15 11:13       ` Jan Kandziora [this message]
2016-07-15 11:26         ` Wolfram Sang
2016-07-15 17:27           ` Jan Kandziora
2016-07-15 18:52           ` Jan Kandziora
2016-07-16  4:51             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5788C54C.20705@gmx.de \
    --to=jjj@gmx.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).