public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v1] i2c: icy: Don't use software node when it's an overkill
Date: Wed, 8 Apr 2020 23:24:20 +0200	[thread overview]
Message-ID: <5867ca8b-215e-5ccf-bee9-feefc2e507c8@enpas.org> (raw)
In-Reply-To: <20200408165247.13116-1-andriy.shevchenko@linux.intel.com>

Thank you, that looks much nicer indeed. I have also tested it on my Amiga just to be sure - it works.


However, no signature yet because the call stack is giving me a headache:

icy_probe()
 -> i2c_new_scanned_device()
 -> i2c_new_client_device()
 -> device_add_properties()

And here we are in drivers/base/property.c looking at device_add_properties():

 * WARNING: The callers should not use this function if it is known that there
 * is no real firmware node associated with @dev! In that case the callers
 * should create a software node and assign it to @dev directly.


Why is this warning there? It flies right in the face of what we're trying to achieve here.

It was introduced in 2018 with commit caf35cd52242 .


So either the warning is superfluous, or i2c_new_client_device() should be creating a software fwnode, I guess?


Thanks
Max


  reply	other threads:[~2020-04-08 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 16:52 [PATCH v1] i2c: icy: Don't use software node when it's an overkill Andy Shevchenko
2020-04-08 21:24 ` Max Staudt [this message]
2020-04-09 10:37   ` Andy Shevchenko
2020-04-09 12:16     ` Heikki Krogerus
2020-04-09 23:51       ` Max Staudt
2020-04-14 14:54         ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5867ca8b-215e-5ccf-bee9-feefc2e507c8@enpas.org \
    --to=max@enpas.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox