From: Neil Armstrong <neil.armstrong@linaro.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Wolfram Sang <wsa@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>
Cc: linux-i2c@vger.kernel.org, Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support
Date: Mon, 20 Nov 2023 09:16:13 +0100 [thread overview]
Message-ID: <58b10e6e-87cd-4157-8541-0cbfeb263422@linaro.org> (raw)
In-Reply-To: <20231119112826.5115-12-hkallweit1@gmail.com>
On 19/11/2023 12:28, Heiner Kallweit wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 52d91a0df..aca5bb086 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi)
> init_completion(&i2c->cmp);
>
> adap = &i2c->adap;
> - adap->class = I2C_CLASS_DDC;
> adap->owner = THIS_MODULE;
> adap->dev.parent = hdmi->dev;
> adap->algo = &dw_hdmi_algorithm;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-11-20 8:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 11:28 [PATCH v3 RESEND 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 03/20] drm/amd/display: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-20 8:16 ` Neil Armstrong [this message]
2023-11-19 11:28 ` [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-20 13:56 ` AngeloGioacchino Del Regno
2023-11-19 11:28 ` [PATCH v3 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-19 22:26 ` Dmitry Baryshkov
2023-11-19 11:28 ` [PATCH v3 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 20/20] include/linux/i2c.h: " Heiner Kallweit
2023-11-19 20:28 ` [PATCH v3 RESEND 00/20] " Helge Deller
2023-11-19 20:48 ` Heiner Kallweit
2023-11-19 20:51 ` Heiner Kallweit
2023-11-19 21:51 ` Helge Deller
-- strict thread matches above, loose matches on Subject: below --
2023-11-19 10:14 [PATCH " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2024-01-22 15:31 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b10e6e-87cd-4157-8541-0cbfeb263422@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hkallweit1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=rfoss@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox